Skip to content

[release/6.0] [AOT] Use .short directive instead of .hword #64637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
safern merged 1 commit into from
Feb 7, 2022
Merged

[release/6.0] [AOT] Use .short directive instead of .hword #64637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[AOT] Use .short directive instead of .hword 
Xamarin.Android is trying to (partially) switch to LLVM-based toolchain
and it appears that the `llvm-mc` assembler doesn't accept `.hword` as a
valid directive for x86 targets.  Since it's an alias for `.short`,
which works fine, the change should be safe across all the architectures
supported by AOT.
  • Loading branch information
@grendello
grendello authored and github-actions committed Feb 1, 2022
commit 0cddc48c55ee70d14e613333a9126b23dfc7b8d7
2 changes: 1 addition & 1 deletion src/mono/mono/mini/image-writer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
#elif defined(TARGET_ASM_GAS) && defined(TARGET_WIN32)
#define AS_INT16_DIRECTIVE ".word"
#elif defined(TARGET_ASM_GAS)
#define AS_INT16_DIRECTIVE ".hword"
#define AS_INT16_DIRECTIVE ".short"
#else
#define AS_INT16_DIRECTIVE ".word"
#endif
Expand Down