-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Send CA names on Linux and OSX #65195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
a0d76d8
23cfd08
717e866
7247db0
09e01eb
9ee8520
17b573c
5cad62d
33fda73
6432d87
27fd404
e064a9d
15cc494
fbba399
e40e1b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -747,6 +747,11 @@ private async ValueTask<int> EnsureFullTlsFrameAsync<TIOAdapter>(CancellationTok | |
| return frameSize; | ||
| } | ||
|
|
||
| if (frameSize < int.MaxValue) | ||
| { | ||
| _buffer.EnsureAvailableSpace(frameSize - _buffer.EncryptedLength); | ||
| } | ||
|
|
||
|
||
| while (_buffer.EncryptedLength < frameSize) | ||
| { | ||
| // there should be space left to read into | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should throw here on failure to be consistent with
SslSetCertificateAuthoritieson macOS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can fail only when maximum number of
STACK_OF(X509_NAME)items is reached (something aroundMAX_INT), so we would not be likely to throw anyway, I added the propagation of the return code for consistency.