Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString #71101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables SString to get out of the UTF16 state and helps move us away from "SString's natural encoding is UTF16"
ghost
added
the
jkotas
reviewed
Jun 21, 2022
jkoritzinsky
commented
Jun 21, 2022
jkotas
reviewed
Jun 21, 2022
jkotas
reviewed
Jun 21, 2022
jkoritzinsky
commented
Jun 21, 2022
Member
Author
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
@jkotas same process applies for SetLiteral, correct?
jkotas
reviewed
Jun 21, 2022
jkotas
reviewed
Jun 21, 2022
Member
Yep |
…w convert the SString itself and in some cases it was already in UTF8) and implement PR feedback.
AaronRobinsonMSFT
approved these changes
Jun 22, 2022
Co-authored-by: Aaron Robinson <[email protected]>
jkotas
reviewed
Jun 22, 2022
jkotas
reviewed
Jun 22, 2022
jkotas
reviewed
Jun 22, 2022
… with a scratch buffer.
…jkoritzinsky/runtime into sstring-getutf8
jkotas
reviewed
Jun 22, 2022
Co-authored-by: Jan Kotas <[email protected]>
Member
Author
|
@jkotas any more feedback? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables SString to get out of the UTF16 state and helps move us away from "SString's natural encoding is UTF16".
This is the first of multiple PRs based on work in #69748.