Skip to content

Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString #71101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 8 commits into from
Jun 23, 2022
Merged

Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString #71101

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
00913ac
Change SString::GetUTF8NoConvert to GetUTF8 that converts the SString
jkoritzinsky Jun 21, 2022
3d8d510
Remove some stack scratch buffers that are unneeded now (as we can no…
jkoritzinsky Jun 21, 2022
9e0754f
Update src/coreclr/utilcode/sstring.cpp
jkoritzinsky Jun 22, 2022
36731bc
Add SetAndConvertToUTF8 method and remove the GetUTF8 method variants…
jkoritzinsky Jun 22, 2022
d4c7bf4
Merge branches 'sstring-getutf8' and 'sstring-getutf8' of github.com:…
jkoritzinsky Jun 22, 2022
ada35f9
Remove unneeded variables.
jkoritzinsky Jun 22, 2022
0162fd9
Merge branch 'main' of github.com:dotnet/runtime into sstring-getutf8
jkoritzinsky Jun 22, 2022
cfd06d1
Apply suggestions from code review
jkoritzinsky Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded variables.
  • Loading branch information
@jkoritzinsky
jkoritzinsky committed Jun 22, 2022
commit ada35f931507e25cbeb529ea5a9da5ef2b845b3b
8 changes: 2 additions & 6 deletions src/coreclr/utilcode/clrconfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,11 @@ namespace
#if defined(DEBUG) && !defined(SELF_NO_HOST)
// Validate the cache and no-cache logic result in the same answer
SString nameToConvert(name);
SString nameAsUTF8;
nameToConvert.ConvertToUTF8(nameAsUTF8);
SString valueAsUTF8;
temp.ConvertToUTF8(valueAsUTF8);

CLRConfigNoCache nonCache = CLRConfigNoCache::Get(nameAsUTF8.GetUTF8(), noPrefix);
CLRConfigNoCache nonCache = CLRConfigNoCache::Get(nameToConvert.GetUTF8(), noPrefix);
LPCSTR valueNoCache = nonCache.AsString();

_ASSERTE(SString::_stricmp(valueNoCache, valueAsUTF8.GetUTF8()) == 0);
_ASSERTE(SString::_stricmp(valueNoCache, temp.GetUTF8()) == 0);
#endif // defined(DEBUG) && !defined(SELF_NO_HOST)
}
}
Expand Down