Remove implicit fallback to reflection-based serialization #71746

eiriktsarpalis · 2022-07-07T01:32:27Z

Makes the following changes:

Remove implicit fallback to reflection-based serialization. Fix Remove implicit fallback to reflection-based serialization in System.Text.Json sourcegen #71714
Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fix JsonSerializerOptions copy constructor should include the metadata resolver #71716. Fix JsonSerializerOptions constructor is not copying the context aspnetcore#38720.
Move reflection-based converter resolution out of JsonSerializerOptions. Fix System.Text.Json GetConverterFromAttribute need to be annotated for native aot #68878

…t#71714 Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fix dotnet#71716 Move reflection-based converter resolution out of JsonSerializerOptions. Fix dotnet#68878

ghost · 2022-07-07T01:32:33Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-07-07T01:32:44Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Makes the following changes:

Remove implicit fallback to reflection-based serialization. Fix Remove implicit fallback to reflection-based serialization in System.Text.Json sourcegen #71714
Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fix JsonSerializerOptions copy constructor should include the metadata resolver #71716. Fix JsonSerializerOptions constructor is not copying the context aspnetcore#38720.
Move reflection-based converter resolution out of JsonSerializerOptions. Fix System.Text.Json GetConverterFromAttribute need to be annotated for native aot #68878

Author:	eiriktsarpalis
Assignees:	-
Labels:	`area-System.Text.Json`, `new-api-needs-documentation`
Milestone:	-

src/libraries/System.Text.Json/ref/System.Text.Json.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

...t.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.Converters.cs

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Helpers.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs

…ion/JsonSerializerContext.cs Co-authored-by: Stephen Toub <[email protected]>

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs

…ibute

...Text.Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonTypeInfo.cs

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs

....Text.Json/tests/System.Text.Json.Tests/Serialization/MetadataTests/MetadataTests.Options.cs

...Text.Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonTypeInfo.cs

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs

...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs

…ion/JsonSerializerOptions.Converters.cs Co-authored-by: Krzysztof Wicher <[email protected]>

Remove implicit fallback to reflection-based serialization. Fix dotne…

708b8cc

…t#71714 Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fix dotnet#71716 Move reflection-based converter resolution out of JsonSerializerOptions. Fix dotnet#68878

ghost added area-System.Text.Json new-api-needs-documentation labels Jul 7, 2022

ghost assigned eiriktsarpalis Jul 7, 2022

eiriktsarpalis requested a review from krwq July 7, 2022 01:32

eiriktsarpalis added this to the 7.0.0 milestone Jul 7, 2022

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/ref/System.Text.Json.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Outdated Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...t.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.Converters.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...t.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.Converters.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...t.Json/src/System/Text/Json/Serialization/Metadata/DefaultJsonTypeInfoResolver.Converters.cs Show resolved Hide resolved

Address feedback & add one more test

9f78a95

stephentoub reviewed Jul 7, 2022

View reviewed changes

...ibraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Helpers.cs Show resolved Hide resolved

stephentoub reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs Outdated Show resolved Hide resolved

eiriktsarpalis and others added 6 commits July 7, 2022 15:29

Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

56b1665

…ion/JsonSerializerContext.cs Co-authored-by: Stephen Toub <[email protected]>

fix build

f829c9b

Bring back throwing behavior in JsonSerializerContext and add tests

98c3349

Only create caching contexts if a resolver is populated

fe511ea

Add null test for JsonSerializerContext interface implementation.

59b4b38

skip RemoteExecutor test in netfx targets

f7e37cd

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs Show resolved Hide resolved

Add DefaultJsonTypeInfoResolver test for types with JsonConverterAttr…

38c4672

…ibute

krwq reviewed Jul 7, 2022

View reviewed changes

...Text.Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonTypeInfo.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

....Text.Json/tests/System.Text.Json.Tests/Serialization/MetadataTests/MetadataTests.Options.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

....Text.Json/tests/System.Text.Json.Tests/Serialization/MetadataTests/MetadataTests.Options.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...Text.Json.Tests/Serialization/MetadataTests/DefaultJsonTypeInfoResolverTests.JsonTypeInfo.cs Show resolved Hide resolved

eiriktsarpalis requested a review from krwq July 7, 2022 20:09

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs Outdated Show resolved Hide resolved

remove nullability annotation

e029c6e

krwq reviewed Jul 7, 2022

View reviewed changes

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs Show resolved Hide resolved

krwq reviewed Jul 7, 2022

View reviewed changes

...ries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Converters.cs Outdated Show resolved Hide resolved

Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…

ed6c70c

…ion/JsonSerializerOptions.Converters.cs Co-authored-by: Krzysztof Wicher <[email protected]>

krwq approved these changes Jul 7, 2022

View reviewed changes

eiriktsarpalis merged commit 8e0a132 into dotnet:main Jul 7, 2022

eiriktsarpalis deleted the jsonserializer-breaking-change branch July 7, 2022 23:23

radical mentioned this pull request Jul 8, 2022

[wasm] STJ.Serialization.Tests failing with System.NotSupportedException with AOT #71838

Closed

ghost locked as resolved and limited conversation to collaborators Aug 7, 2022

Remove implicit fallback to reflection-based serialization #71746

Remove implicit fallback to reflection-based serialization #71746

Uh oh!

Conversation

eiriktsarpalis commented Jul 7, 2022

Uh oh!

ghost commented Jul 7, 2022

Uh oh!

ghost commented Jul 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants