Skip to content

Remove implicit fallback to reflection-based serialization #71746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 11 commits into from
Jul 7, 2022
Merged

Remove implicit fallback to reflection-based serialization #71746

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
708b8cc
Remove implicit fallback to reflection-based serialization. Fix #71714
eiriktsarpalis Jul 7, 2022
9f78a95
Address feedback & add one more test
eiriktsarpalis Jul 7, 2022
56b1665
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
eiriktsarpalis Jul 7, 2022
f829c9b
fix build
eiriktsarpalis Jul 7, 2022
98c3349
Bring back throwing behavior in JsonSerializerContext and add tests
eiriktsarpalis Jul 7, 2022
fe511ea
Only create caching contexts if a resolver is populated
eiriktsarpalis Jul 7, 2022
59b4b38
Add null test for JsonSerializerContext interface implementation.
eiriktsarpalis Jul 7, 2022
f7e37cd
skip RemoteExecutor test in netfx targets
eiriktsarpalis Jul 7, 2022
38c4672
Add DefaultJsonTypeInfoResolver test for types with JsonConverterAttr…
eiriktsarpalis Jul 7, 2022
e029c6e
remove nullability annotation
eiriktsarpalis Jul 7, 2022
ed6c70c
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
eiriktsarpalis Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat… 
…ion/JsonSerializerContext.cs

Co-authored-by: Stephen Toub <[email protected]>
  • Loading branch information
@eiriktsarpalis @stephentoub
eiriktsarpalis and stephentoub authored Jul 7, 2022
commit 56b166522ece2625f85ec7083588c2b940702924
14 changes: 2 additions & 12 deletions src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,8 @@ public abstract partial class JsonSerializerContext : IJsonTypeInfoResolver
/// <remarks>
/// The options instance cannot be mutated once it is bound to the context instance.
/// </remarks>
public JsonSerializerOptions Options
{
get
{
if (_options is null)
{
var options = new JsonSerializerOptions { TypeInfoResolver = this, IsLockedInstance = true };
_options = options;
}

return _options;
}
public JsonSerializerOptions Options =>
_options ??= new JsonSerializerOptions { TypeInfoResolver = this, IsLockedInstance = true };

internal set
{
Expand Down