Skip to content

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jul 24, 2022

This global flag was defined in between the extern C qualifier and the export statement. This resulted in hidden visibility and a mangled symbol export. Pull it out of the signature.

@hoyosjs hoyosjs requested a review from a team July 24, 2022 11:12
@ghost
Copy link

ghost commented Jul 24, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned hoyosjs Jul 24, 2022
@hoyosjs
Copy link
Member Author

hoyosjs commented Jul 24, 2022

/backport to release/7.0-preview7

@github-actions
Copy link
Contributor

Started backporting to release/7.0-preview7: https://github.com/dotnet/runtime/actions/runs/2727025383

@ghost
Copy link

ghost commented Jul 24, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

This global flag was defined in between the extern C qualifier and the export statement. This resulted in hidden visibility and a mangled symbol export. Pull it out of the signature.

Author: hoyosjs
Assignees: hoyosjs
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs hoyosjs merged commit 60cfaec into dotnet:main Jul 25, 2022
@hoyosjs hoyosjs deleted the juhoyosa/fix-m1-debug branch July 25, 2022 08:34
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants