[release/7.0-preview7] Fix ARM64 Unix debugging #72736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #72735 to release/7.0-preview7 /cc @hoyosjs Customer ImpactAll debugging on ARM64 Linux and macOS on coreclr will fail at startup without this change. TestingManual testing. RiskVery low - reverts to prior behavior.
|
jkotas
approved these changes
Jul 24, 2022
tommcdon
approved these changes
Jul 24, 2022
jeffschwMSFT
approved these changes
Jul 25, 2022
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We will take for consideration for 7.0 preview 7
Member
Member
|
It's WASM linkage - I'll take a look but this change only touches CoreCLR's mscordbi, so it can't be the cause. |
Member
|
@lewing @steveisok Looks like NPM audits are failing |
hoyosjs
added
Servicing-approved
Member
|
Approved offline. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #72735 to release/7.0-preview7
/cc @hoyosjs
Customer Impact
All debugging on ARM64 Linux and macOS on coreclr will fail at startup without this change.
Testing
Manual testing.
Risk
Very low - reverts to prior behavior.