[wasm] Use new javascript API in tests and samples #74153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maraf merged 6 commits into dotnet:main from maraf:WasmJsApiPart2

Aug 22, 2022

Member

maraf commented Aug 18, 2022 •

edited by pavelsavara

Loading

Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
Add guard in withApplicationArgumentsFromQuery for window object.

Contributes to #72990

maraf added 3 commits

August 18, 2022 12:35


          Check window exists in the withApplicationArgumentsFromQuery.

2d27a33


          Comment about withModuleConfig use.

a530c57


          Rewrite samples and tests.

8541d1b

maraf added arch-wasm area-Build-mono labels

maraf self-assigned this

maraf requested review from lewing, marek-safar and pavelsavara as code owners

August 18, 2022 15:35

ghost commented Aug 18, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Replace createDotnetRuntime with new dotnet builder API in sapmles and tests.
Add guard in withApplicationArgumentsFromQuery for window object.

Author:	maraf
Assignees:	maraf
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

Member Author

maraf commented Aug 18, 2022

/azp run runtime-wasm

azure-pipelines bot commented Aug 18, 2022

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-bench/frame-main.js Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-bench/main.js Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-nextjs/components/deepThought.js Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-nextjs/components/deepThought.js Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-profile/README.md Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-profile/main.js Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser-threads/main.js Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/browser/main.js Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/mono/sample/wasm/console-node-ts/main.ts Outdated Show resolved Hide resolved

pavelsavara reviewed

View reviewed changes

src/tests/FunctionalTests/WebAssembly/Browser/HotReload/main.js Outdated Show resolved Hide resolved

maraf changed the title ~~[wasm] Use mew javascript API in tests and samples~~ [wasm] Use new javascript API in tests and samples

maraf added 3 commits

August 19, 2022 10:56


          Feedback.

dac18be


          Merge remote-tracking branch 'upstream/main' into WasmJsApiPart2

b38e296


          Drop commented code.

1bd2820

Member Author

maraf commented Aug 19, 2022

/azp run runtime-wasm

azure-pipelines bot commented Aug 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara approved these changes

View reviewed changes

maraf merged commit 8cf96d9 into dotnet:main

maraf deleted the WasmJsApiPart2 branch

August 22, 2022 14:47

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm area-Build-mono