Skip to content

[wasm] Use new javascript API in tests and samples #74153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 6 commits into from
Aug 22, 2022
Merged

[wasm] Use new javascript API in tests and samples #74153

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d27a33
Check window exists in the withApplicationArgumentsFromQuery.
maraf Aug 18, 2022
a530c57
Comment about withModuleConfig use.
maraf Aug 18, 2022
8541d1b
Rewrite samples and tests.
maraf Aug 18, 2022
dac18be
Feedback.
maraf Aug 19, 2022
b38e296
Merge remote-tracking branch 'upstream/main' into WasmJsApiPart2
maraf Aug 19, 2022
1bd2820
Drop commented code.
maraf Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check window exists in the withApplicationArgumentsFromQuery.
  • Loading branch information
@maraf
maraf committed Aug 18, 2022
commit 2d27a335e3ca85934cd904ba9cc574536e28d0a9
16 changes: 10 additions & 6 deletions src/mono/wasm/runtime/run-outer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,17 @@ class HostBuilder implements DotnetHostBuilder {

withApplicationArgumentsFromQuery(): DotnetHostBuilder {
try {
if (typeof globalThis.URLSearchParams != "undefined") {
const params = new URLSearchParams(window.location.search);
const values = params.getAll("arg");
return this.withApplicationArguments(...values);
if (!globalThis.window) {
throw new Error("Missing window to the query parameters from");
}

throw new Error("URLSearchParams is supported");

if (typeof globalThis.URLSearchParams == "undefined") {
throw new Error("URLSearchParams is supported");
}

const params = new URLSearchParams(window.location.search);
const values = params.getAll("arg");
return this.withApplicationArguments(...values);
} catch (err) {
mono_exit(1, err);
throw err;
Expand Down