Skip to content

Conversation

@yamachu
Copy link
Contributor

@yamachu yamachu commented Aug 18, 2022

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

@ghost ghost added area-System.Runtime.InteropServices.JavaScript community-contribution Indicates that the PR has been added by a community member labels Aug 18, 2022
@lewing lewing requested a review from maraf August 18, 2022 18:43
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@maraf maraf added the arch-wasm WebAssembly architecture label Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

With #73785 , dotnet and exit are now public APIs with named exports.

When developing in TypeScript, importing dotnet did not work for type completion.
So I added those to d.ts .

Author: yamachu
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, community-contribution

Milestone: -

@maraf maraf merged commit e23f543 into dotnet:main Aug 19, 2022
@maraf
Copy link
Member

maraf commented Aug 19, 2022

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2887864418

@yamachu yamachu deleted the add-dotnet-exports-type branch August 19, 2022 07:41
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants