Skip to content

CI: Fix helix test results reporting #74788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 2 commits into from
Aug 30, 2022
Merged

CI: Fix helix test results reporting #74788

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749dcc6
CI: Fix helix test results reporting
radical Aug 29, 2022
4987c0a
Disable failing tests, see https://github.com/dotnet/runtime/issues/7…
akoeplinger Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CI: Fix helix test results reporting 
PR #73060 broke uploading of helix test results. This was caused by the
change:

```xml
      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```

This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by *appending* to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes #74699 .
  • Loading branch information
@radical
radical committed Aug 29, 2022
commit 749dcc6266be4b4bb6cc424f837549de044425a2
4 changes: 2 additions & 2 deletions src/libraries/sendtohelixhelp.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@
</PropertyGroup>

<PropertyGroup>
<HelixPreCommands>@(HelixPreCommand)</HelixPreCommands>
<HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
<HelixPreCommands>$(HelixPreCommands);@(HelixPreCommand)</HelixPreCommands>
<HelixPostCommands>$(HelixPostCommands);@(HelixPostCommand)</HelixPostCommands>
<HelixCommandPrefix Condition="'$(WindowsShell)' == 'true' and @(HelixCommandPrefixItem->Count()) > 0" >$(HelixCommandPrefix) @(HelixCommandPrefixItem -> 'set &quot;%(Identity)&quot;', ' &amp; ')</HelixCommandPrefix>
<HelixCommandPrefix Condition="'$(WindowsShell)' != 'true' and @(HelixCommandPrefixItem->Count()) > 0 ">$(HelixCommandPrefix) @(HelixCommandPrefixItem, ' ')</HelixCommandPrefix>
<IncludeHelixCorrelationPayload Condition="'$(IncludeHelixCorrelationPayload)' == '' and '$(HelixCorrelationPayload)' != ''">true</IncludeHelixCorrelationPayload>
Expand Down