Ensure that the SSE fallback for Vector3.Dot masks off the unused element of op1 and op2 #74932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment of op1 and op2
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #74857
|
Member
Author
|
CC. @jkotas |
jkotas
reviewed
Sep 1, 2022
jkotas
approved these changes
Sep 1, 2022
Member
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
Looks good to me. Somebody on @dotnet/jit-contrib should take a look as well.
EgorBo
approved these changes
Sep 1, 2022
Member
|
Thanks @tannergooding. Please backport to 7.0 once CI is green. |
Member
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2976383148 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #72149