Skip to content

Disabling disasm checks under certain testing environments #76202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 10 commits into from
Sep 27, 2022
Merged

Disabling disasm checks under certain testing environments #76202

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
55d626a
Disabling disasm checks under certain testing environments
TIHan Sep 26, 2022
9f35945
Add extra linux musl check
TIHan Sep 26, 2022
f94b5ab
Add JitDisasm check back
TIHan Sep 26, 2022
65cb4fd
Remove JitDisasm check
TIHan Sep 26, 2022
c35b1db
Re-enable musl
TIHan Sep 26, 2022
95adaf6
Do not run disasm checks under stress modes
TIHan Sep 26, 2022
b27a908
Feedback, force a failure
TIHan Sep 26, 2022
c0e1a8e
Trying to fix targets
TIHan Sep 27, 2022
b2a0b5f
Trying to fix targets
TIHan Sep 27, 2022
4bfdbb7
Update Runtime_34937.cs
TIHan Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable musl
  • Loading branch information
@TIHan
TIHan committed Sep 26, 2022
commit c35b1db43b4a3f9d97d982de096387b2e995b0bf
2 changes: 1 addition & 1 deletion src/tests/Common/CLRTest.Jit.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ IF NOT DEFINED DoLink (
DependsOnTargets="GetDisasmCheckData">
<PropertyGroup>
<HasBashDisasmCheck>false</HasBashDisasmCheck>
<HasBashDisasmCheck Condition="'$(HasDisasmCheck)' == 'true' and '$(RuntimeFlavor)' == 'coreclr' and ('$(TargetOS)' == 'Linux' or '$(TargetOS)' == 'OSX') and ('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64') and '$(RunCrossGen2)' != 'true' and '$(RuntimeIdentifier)' != 'linux-musl-arm64' and '$(RuntimeIdentifier)' != 'linux-musl-arm' and '$(RuntimeIdentifier)' != 'linux-musl-x64'">true</HasBashDisasmCheck>
<HasBashDisasmCheck Condition="'$(HasDisasmCheck)' == 'true' and '$(RuntimeFlavor)' == 'coreclr' and ('$(TargetOS)' == 'Linux' or '$(TargetOS)' == 'OSX') and ('$(TargetArchitecture)' == 'x64' or '$(TargetArchitecture)' == 'arm64') and '$(RunCrossGen2)' != 'true'">true</HasBashDisasmCheck>
Copy link
Contributor

@markples markples Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could fold the RunCrossGen2 check into GetDisasmCheckData and then not duplicate it on the bash/batch sides.

Copy link
Contributor Author

@TIHan TIHan Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I can also do the setting of GCStressIncompatible/HeapVerifyIncompatible well too.

Copy link
Contributor

@markples markples Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<EDIT: removed my comment about the Incompatible vars because it was wrong>


<GCStressIncompatible Condition="'$(HasBashDisasmCheck)' == 'true'">true</GCStressIncompatible>
<HeapVerifyIncompatible Condition="'$(HasBashDisasmCheck)' == 'true'">true</HeapVerifyIncompatible>
Copy link
Contributor

@markples markples Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious to know the restrictions here. I thought these "just" impacted the runtime - do they change the codegen and therefore the disasm output?

Copy link
Contributor Author

@TIHan TIHan Sep 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure - we should probably ask.
@AndyAyersMS - Does GCStress/HeapVerify impact codegen at all?

Copy link
Contributor

@markples markples Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear - ok to disable and merge - just wondering about the future steps

Expand Down