Increase distributed transaction test timeout for MSDTC communication failures #76892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @roji Issue DetailsIncreasing the timeout again, from 30 seconds to 5 minutes (see previous #76310). If this still doesn't work reliably, I'll simply ignore these specific test failures (which are about communication to the MSDTC). Closes #76836 /cc @BruceForstall @ajcvickers
|
BruceForstall
approved these changes
Oct 11, 2022
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM. You might get to the point where the outer test driver timeout hits before your internal timeout.
ajcvickers
approved these changes
Oct 11, 2022
Contributor
|
@roji It doesn't look like this helped. There are still failures in a run that happened with this change: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the timeout again, from 30 seconds to 5 minutes (see previous #76310). If this still doesn't work reliably, I'll simply ignore these specific test failures (which are about communication to the MSDTC).
Closes #76836
/cc @BruceForstall @ajcvickers