Skip to content

Increase distributed transaction test timeout for MSDTC communication failures #76892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Oct 12, 2022
Merged

Increase distributed transaction test timeout for MSDTC communication failures #76892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Transactions.Local/tests/OleTxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,8 @@ private static void Test(Action action)

// In CI, we sometimes get XACT_E_TMNOTAVAILABLE; when it happens, it's typically on the very first
// attempt to connect to MSDTC (flaky/slow on-demand startup of MSDTC), though not only.
// This catches that error and retries.
int nRetries = 60;
// This catches that error and retries: 5 minutes of retries, with a second between them.
int nRetries = 60 * 5;

while (true)
{
Expand All @@ -596,7 +596,7 @@ private static void Test(Action action)
throw;
}

Thread.Sleep(500);
Thread.Sleep(1000);
}
}
}
Expand All @@ -605,7 +605,7 @@ private static void Test(Action action)
// so allow some time for assertions to succeed.
private static void Retry(Action action)
{
const int Retries = 50;
const int Retries = 100;

for (var i = 0; i < Retries; i++)
{
Expand Down