Skip to content

Fix relative symlink support in TarFile #77338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jozkee merged 2 commits into from
Nov 11, 2022
Merged

Fix relative symlink support in TarFile #77338

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b99de4
Fix relative symlink support in TarFile
am11 Nov 3, 2022
4cffab3
Update src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateF…
am11 Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateF… 
…romDirectory.File.Roundtrip.cs

Co-authored-by: David Cantú <[email protected]>
  • Loading branch information
@am11 @jozkee
am11 and jozkee authored Nov 11, 2022
commit 4cffab33943dc4b00ca505a3e530d1b0db1a281b
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/tests/TarFile/TarFile.CreateFromDirectory.File.Roundtrip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void SymlinkRelativeTargets_OutsideTheArchive_Fails(string symlinkTargetP
TarFile.CreateFromDirectory(sourceDirectoryName, destinationArchive, includeBaseDirectory: false);

using FileStream archiveStream = File.OpenRead(destinationArchive);
Exception exception = Record.Exception(() => TarFile.ExtractToDirectory(archiveStream, destinationDirectoryName, overwriteFiles: true));
Exception exception = Assert.Throws<IOException>(() => TarFile.ExtractToDirectory(archiveStream, destinationDirectoryName, overwriteFiles: true));

Assert.Equal(SR.Format(SR.TarExtractingResultsLinkOutside, symlinkTargetPath, destinationDirectoryName), exception.Message);
}
Expand Down