Skip to content

Improve IndexOfAnyAsciiSearcher ARM throughput #78739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaZupan merged 2 commits into from
Nov 23, 2022
Merged

Improve IndexOfAnyAsciiSearcher ARM throughput #78739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec1f5d
Improve IndexOfAnyAsciiSearcher ARM throughput
MihaZupan Nov 22, 2022
5890146
Remove type name asserts
MihaZupan Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove type name asserts
  • Loading branch information
@MihaZupan
MihaZupan committed Nov 23, 2022
commit 58901460efc1a497bea63904aaa30f325833bdb2
1 change: 0 additions & 1 deletion src/libraries/System.Memory/tests/Span/IndexOfAny.byte.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,6 @@ public static void AsciiNeedle_ProperlyHandlesEdgeCases_Byte(bool needleContains
// There is some special handling we have to do for ASCII needles to properly filter out non-ASCII results
ReadOnlySpan<byte> needleValues = needleContainsZero ? "AEIOU\0"u8 : "AEIOU!"u8;
IndexOfAnyValues<byte> needle = IndexOfAnyValues.Create(needleValues);
Assert.Contains("Ascii", needle.GetType().Name);

ReadOnlySpan<byte> repeatingHaystack = "AaAaAaAaAaAa"u8;
Assert.Equal(0, repeatingHaystack.IndexOfAny(needle));
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Memory/tests/Span/IndexOfAny.char.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,6 @@ public static void AsciiNeedle_ProperlyHandlesEdgeCases_Char(bool needleContains
// There is some special handling we have to do for ASCII needles to properly filter out non-ASCII results
ReadOnlySpan<char> needleValues = needleContainsZero ? "AEIOU\0" : "AEIOU!";
IndexOfAnyValues<char> needle = IndexOfAnyValues.Create(needleValues);
Assert.Contains("Ascii", needle.GetType().Name);

ReadOnlySpan<char> repeatingHaystack = "AaAaAaAaAaAa";
Assert.Equal(0, repeatingHaystack.IndexOfAny(needle));
Expand Down