[PERF] Make mono dotnet pathing dynamic with proj file #78787
Conversation
This reverts commit 259172133e5fa220c14e032d6b328138e6f22721.
…er was one layer deeper than expected.
…the MSBuild task was not being found.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis is another version of , that uses a proj file instead of string searching Versions.props files. This fixes dotnet/performance#2733 and will help minimize the changes we need to make to keep these values up to date.
|
| steps: | ||
| # Extra steps that will be passed to the performance template and run before sending the job to helix (all of which is done in the template) | ||
| - script: | | ||
| $(Build.SourcesDirectory)/eng/common/msbuild.sh $(Build.SourcesDirectory)/eng/testing/performance/add_properties_to_pipeline.proj |
There was a problem hiding this comment.
Although there's only one target in proj file, I would explicitly specify it (/t:) to future-proof it.
ghost
added
needs-author-action
LoopedBard3
force-pushed
the
PerfMakeMonoDotnetPathingDynamicWithProjFile
branch
from
765fe7a to
82fc583
Compare
|
This is ready for merge with successful run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2055044&view=results. |
|
This doesn't affect any of the runs/flows outside of the perf-pipeline. Merging after full test results are in: https://dev.azure.com/dnceng/internal/_build/results?buildId=2055585&view=results |
|
Test run succeeded in primary targeted areas and many potentially affected areas came back green, merging. |
3 participants
This is another version of #78581, that uses a proj file instead of string searching Versions.props files. This fixes dotnet/performance#2733 and will help minimize the changes we need to make to keep these values up to date.