Skip to content

[PERF] Make mono dotnet pathing dynamic with proj file #78787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 14 commits into from
Nov 29, 2022
Merged

[PERF] Make mono dotnet pathing dynamic with proj file #78787

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a7f3ab1
Added the proj file that prints the variables we need in the azure pi…
LoopedBard3 Nov 21, 2022
93cd2a0
Setup testing.
LoopedBard3 Nov 17, 2022
52675a6
Added the steps to run the new properties pipeline.proj file.
LoopedBard3 Nov 21, 2022
8299014
Move the script msbuild part to the perf-job.yml as the steps paramet…
LoopedBard3 Nov 21, 2022
44b569d
Switch to using the MSBuild task as msbuild was not found in the scri…
LoopedBard3 Nov 21, 2022
f2e64c3
Try using the dotnet core cli msbuild instead of the MSBuild task as …
LoopedBard3 Nov 23, 2022
5af29f6
Try using the eng provided msbuild.sh bash script.
LoopedBard3 Nov 23, 2022
4238806
Use the correct format for the sourcesDirectory Env Variable.
LoopedBard3 Nov 23, 2022
849a009
Use the correct slash for path in bash.
LoopedBard3 Nov 23, 2022
82fc583
Add /t: to the msbuild command.
LoopedBard3 Nov 28, 2022
5fa6c9a
Add the usage of the product version to verify it working.
LoopedBard3 Nov 28, 2022
7fc86d7
Add quotes to the proj exec command to see if that fixes the printing.
LoopedBard3 Nov 28, 2022
90dcd95
Add additional echo after the product version for easier debugging do…
LoopedBard3 Nov 28, 2022
1221feb
Revert "Setup testing."
LoopedBard3 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add /t: to the msbuild command.
  • Loading branch information
@LoopedBard3
LoopedBard3 committed Nov 28, 2022
commit 82fc583958e7216adb4e85e1fbb4c53f54f617d5
2 changes: 1 addition & 1 deletion eng/pipelines/coreclr/templates/perf-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
steps:
# Extra steps that will be passed to the performance template and run before sending the job to helix (all of which is done in the template)
- script: |
$(Build.SourcesDirectory)/eng/common/msbuild.sh $(Build.SourcesDirectory)/eng/testing/performance/add_properties_to_pipeline.proj
$(Build.SourcesDirectory)/eng/common/msbuild.sh $(Build.SourcesDirectory)/eng/testing/performance/add_properties_to_pipeline.proj /t:SetVariables
displayName: Add Properties To Pipeline Env

# Optionally download live-built libraries
Expand Down