Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 11, 2023

Apply @jakobbotsch's patch

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2023
@ghost ghost assigned EgorBo Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #84631 ?

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo EgorBo marked this pull request as ready for review April 11, 2023 21:10
@EgorBo
Copy link
Member Author

EgorBo commented Apr 11, 2023

@jakobbotsch can you help me here, I'm a bit confused - the assert is still here or I'm looking at old logs? I was not able to repro it locally after your fix

@tannergooding
Copy link
Member

The CI logs are showing the latest PR commit: 89d8c9a

But SPMI is indeed still raising the assert in the logs as well.

@tannergooding
Copy link
Member

Ah, and this PR covers only lists (C:\h\w\AA60093B\p\base\checked\clrjit_win_x64_x64.dll)

Where-as the previous lists both a \base\ and a \diff\ set

@BruceForstall
Copy link
Contributor

Looks like 5 failures still, in libraries_tests.pmi

@jakobbotsch
Copy link
Member

The baseline is going to keep failing until we get new rolling builds with both this and #84588.

@BruceForstall
Copy link
Contributor

Ah right, I didn't notice the failure was only in the baseline here. So, ready to merge then?

@EgorBo EgorBo merged commit a5b143c into dotnet:main Apr 11, 2023
@EgorBo EgorBo deleted the fix-spmi-assert branch April 11, 2023 23:32
@EgorBo
Copy link
Member Author

EgorBo commented Apr 11, 2023

Thanks! I didn't realize it's the baseline so it confused me a lot 🙂

@EgorBo
Copy link
Member Author

EgorBo commented Apr 11, 2023

I see the a new SPMI is being collected now after Kunal's PR merged today - presumably it will fail because it doesn't have this fix?

@BruceForstall
Copy link
Contributor

SPMI collection itself won't fail; it will filter out any JIT failures.

We'll want to re-run collection after both fixes (this and #84588) are merged. Also, we need to wait until #84649 is merged

@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants