Skip to content

fix gtSplitTree assert #84634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EgorBo merged 2 commits into from
Apr 11, 2023
Merged

fix gtSplitTree assert #84634

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86dc26e
fix gtSplitTree assert
EgorBo Apr 11, 2023
89d8c9a
Apply Jakob's patch
EgorBo Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply Jakob's patch
  • Loading branch information
@EgorBo
EgorBo committed Apr 11, 2023
commit 89d8c9aa7f0798660c15a6f9bc8ecb95bd32d98a
15 changes: 11 additions & 4 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16265,10 +16265,6 @@ bool Compiler::gtSplitTree(

bool IsValue(const UseInfo& useInf)
{
if ((*useInf.Use)->TypeIs(TYP_VOID))
{
return false;
}
GenTree* node = (*useInf.Use)->gtEffectiveVal();
if (!node->IsValue())
{
Expand All @@ -16292,6 +16288,17 @@ bool Compiler::gtSplitTree(
return false;
}

if (user->OperIs(GT_CALL))
{
for (CallArg& callArg : user->AsCall()->gtArgs.Args())
{
if ((&callArg.EarlyNodeRef() == useInf.Use) && (callArg.GetLateNode() != nullptr))
{
return false;
}
}
}

return true;
}

Expand Down