Fix R2R test build #84952
Merged
Fix R2R test build #84952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
trylek
approved these changes
Apr 17, 2023
Member
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Beautiful, thanks Sven for the super fast turnaround in providing the fix!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84949.
#84148 broke the outerloop R2R jobs, because the x64 musl build became a cross build, but the R2R test compilation did not use the x64 glibc hosted crossgen2.
Validated by running the failing build command
locally in the mariner build image. I observed the same failure as in ci, and validated that this fixed it.