Skip to content

Conversation

@trylek
Copy link
Member

@trylek trylek commented Apr 17, 2023

After several fixes and additions to issues.targets I'm now seeing a relatively limited set of tests failing on Windows arm with a nullref tracked under

#84818

This should finally let us see a green outerloop run despite the fact that some additional rare failures still remain, I've seen a few in the runs from the last couple of days.

Thanks

Tomas

P.S. At this point I'm not adding the tlstest_il_r test Mark quotes in the issue title as it seems to be one of the tests hitting this less often, I'm adding the tests that failed in each of the 10 or so most recent outerloop runs I looked at.

/cc @dotnet/runtime-infrastructure

After several fixes and additions to issues.targets I'm now seeing
a relatively limited set of tests failing on Windows arm with
a nullref tracked under

dotnet#84818

This should finally let us see a green outerloop run despite the
fact that some additional rare failures still remain, I've seen
a few in the runs from the last couple of days.

Thanks

Tomas
@trylek
Copy link
Member Author

trylek commented Apr 17, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...I will probably revert this commit once I send PR for the tls issue.

@trylek
Copy link
Member Author

trylek commented Apr 17, 2023

That sounds very reasonable especially as there's obviously no guarantee that all the nullrefs we're seeing have the same root cause.

@trylek
Copy link
Member Author

trylek commented Apr 17, 2023

Funnily enough the outerloop test I triggered for this PR did hit the tlstest_il_r failure. I'm waiting for the remaining jobs to finish and based on their results I'll probably try to rerun the one job even though that still won't let me get to a green run due to the pending musl bug #84949. I find that the most important right now as it's blocking clean CI, thankfully @janvorli seems to have insight into what's going on and he's working with @sbomer on resolving the issue.

@kunalspathak
Copy link
Contributor

kunalspathak commented Apr 17, 2023

did hit the tlstest_il_r failure.

I have opened #84954 to fix this. Let us wait for outerloop for that PR to complete and see how many of them get addressed.

@trylek
Copy link
Member Author

trylek commented Apr 17, 2023

Still not completely green but much better than the previous runs, merging in; Sven has already managed to put up the PR for fixing the musl build break in #84952.

@trylek trylek merged commit 80ce3b6 into dotnet:main Apr 17, 2023
@trylek trylek deleted the IssuesTargets84818 branch April 17, 2023 22:55
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Apr 18, 2023
kunalspathak added a commit that referenced this pull request Apr 18, 2023
* Disable TLS field access for Arm

* Update src/coreclr/jit/helperexpansion.cpp

Co-authored-by: Bruce Forstall <[email protected]>

* Revert "Add issues.targets entries for four tests failing on Windows arm (#84943)"

This reverts commit 80ce3b6.

---------

Co-authored-by: Bruce Forstall <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants