-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add issues.targets entries for four tests failing on Windows arm #84943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After several fixes and additions to issues.targets I'm now seeing a relatively limited set of tests failing on Windows arm with a nullref tracked under dotnet#84818 This should finally let us see a green outerloop run despite the fact that some additional rare failures still remain, I've seen a few in the runs from the last couple of days. Thanks Tomas
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kunalspathak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...I will probably revert this commit once I send PR for the tls issue.
|
That sounds very reasonable especially as there's obviously no guarantee that all the nullrefs we're seeing have the same root cause. |
|
Funnily enough the outerloop test I triggered for this PR did hit the |
I have opened #84954 to fix this. Let us wait for outerloop for that PR to complete and see how many of them get addressed. |
|
Still not completely green but much better than the previous runs, merging in; Sven has already managed to put up the PR for fixing the musl build break in #84952. |
…arm (dotnet#84943)" This reverts commit 80ce3b6.
* Disable TLS field access for Arm * Update src/coreclr/jit/helperexpansion.cpp Co-authored-by: Bruce Forstall <[email protected]> * Revert "Add issues.targets entries for four tests failing on Windows arm (#84943)" This reverts commit 80ce3b6. --------- Co-authored-by: Bruce Forstall <[email protected]>
After several fixes and additions to issues.targets I'm now seeing a relatively limited set of tests failing on Windows arm with a nullref tracked under
#84818
This should finally let us see a green outerloop run despite the fact that some additional rare failures still remain, I've seen a few in the runs from the last couple of days.
Thanks
Tomas
P.S. At this point I'm not adding the
tlstest_il_rtest Mark quotes in the issue title as it seems to be one of the tests hitting this less often, I'm adding the tests that failed in each of the 10 or so most recent outerloop runs I looked at./cc @dotnet/runtime-infrastructure