Skip to content

Disable TLS field access for Arm #84954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunalspathak merged 5 commits into from
Apr 18, 2023
Merged

Disable TLS field access for Arm #84954

kunalspathak merged 5 commits into from
Apr 18, 2023

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Apr 17, 2023

TEB on Arm32 is accessed using co-processor registers and today we do not support them, or the instructions needed for them. Disable TLS access for Arm32.

Fixes: #84818

References:

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 17, 2023
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 17, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 17, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak kunalspathak mentioned this pull request Apr 17, 2023
Merged
BruceForstall
BruceForstall reviewed Apr 18, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Apr 18, 2023
Closed
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 18, 2023 •
edited
Loading

I am trying to revert #84943 and see if outerloop is clean for windows-arm.
cc: @trylek

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 18, 2023

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 18, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Apr 18, 2023

@trylek - Looks like all the issues are fixed with this.

trylek
trylek approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Kunal for fixing this!

@kunalspathak kunalspathak merged commit 9314a38 into dotnet:main Apr 18, 2023
@kunalspathak kunalspathak deleted the tls-arm branch April 18, 2023 23:28
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylek trylek trylek approved these changes

+1 more reviewer

@BruceForstall BruceForstall BruceForstall left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intermittent failure in JIT/Directed/coverage/oldtests/tlstest_il_r/tlstest.dll

3 participants

@kunalspathak @BruceForstall @trylek