Skip to content

[nativeaot][tests] Update bundle zip path for NativeAOT sample app #87049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 15 commits into from
Jun 5, 2023
Merged

[nativeaot][tests] Update bundle zip path for NativeAOT sample app #87049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e53fdd2
Update bundle zip path for NativeAOT sample app
kotlarmilos Jun 2, 2023
599971d
Test perf pipeline
kotlarmilos Jun 2, 2023
904b592
Add shared path for Mono and Native AOT
kotlarmilos Jun 2, 2023
402e656
Use common display name
kotlarmilos Jun 2, 2023
c0c2a88
Use common display name
kotlarmilos Jun 2, 2023
a24ba92
Use common display name
kotlarmilos Jun 2, 2023
c646652
Parametrize bundle download step
kotlarmilos Jun 2, 2023
d0763db
Parametrize bundle download step
kotlarmilos Jun 2, 2023
779a8aa
Parametrize bundle download step
kotlarmilos Jun 2, 2023
d596c72
Parametrize bundle download step
kotlarmilos Jun 2, 2023
851dbd8
Update Helix item name and fix find command
kotlarmilos Jun 2, 2023
4bc3259
Update Helix item name and fix bundle path
kotlarmilos Jun 2, 2023
29d3935
Add runtime type parameter
kotlarmilos Jun 2, 2023
b16484e
Enable other jobs
kotlarmilos Jun 2, 2023
51f4ac0
Remove duplicate property
kotlarmilos Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Parametrize bundle download step
  • Loading branch information
@kotlarmilos
kotlarmilos committed Jun 2, 2023
commit d596c725d032829c0f9dcc4f4f5621075af7fd20
7 changes: 6 additions & 1 deletion eng/pipelines/coreclr/templates/perf-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,19 +234,24 @@ jobs:
parameters:
unpackFolder: $(Build.SourcesDirectory)/iosHelloWorld
cleanUnpackFolder: false
artifactFileName: 'iOSSampleApp.zip'
${{ if and(eq(parameters.runtimeType, 'iOSMono'), eq(parameters.iOSLlvmBuild, 'False'), eq(parameters.iOSStripSymbols, 'False')) }}:
artifactName: 'iOSSampleAppNoLLVMSymbols'
artifactFileName: 'iOSSampleAppNoLLVMSymbols.zip'
${{ if and(eq(parameters.runtimeType, 'iOSMono'), eq(parameters.iOSLlvmBuild, 'False'), eq(parameters.iOSStripSymbols, 'True')) }}:
artifactName: 'iOSSampleAppNoLLVMNoSymbols'
artifactFileName: 'iOSSampleAppNoLLVMNoSymbols.zip'
${{ if and(eq(parameters.runtimeType, 'iOSMono'), eq(parameters.iOSLlvmBuild, 'True'), eq(parameters.iOSStripSymbols, 'False')) }}:
artifactName: 'iOSSampleAppLLVMSymbols'
artifactFileName: 'iOSSampleAppLLVMSymbols.zip'
${{ if and(eq(parameters.runtimeType, 'iOSMono'), eq(parameters.iOSLlvmBuild, 'True'), eq(parameters.iOSStripSymbols, 'True')) }}:
artifactName: 'iOSSampleAppLLVMNoSymbols'
artifactFileName: 'iOSSampleAppLLVMNoSymbols.zip'
${{ if and(eq(parameters.runtimeType, 'iOSNativeAOT'), eq(parameters.iOSStripSymbols, 'False')) }}:
artifactName: 'iOSSampleAppSymbols'
artifactFileName: 'iOSSampleAppSymbols.zip'
${{ if and(eq(parameters.runtimeType, 'iOSNativeAOT'), eq(parameters.iOSStripSymbols, 'True')) }}:
artifactName: 'iOSSampleAppNoSymbols'
artifactFileName: 'iOSSampleAppNoSymbols.zip'
displayName: 'iOS Sample App'
# same artifact as above but don't extract .zip
- task: DownloadBuildArtifacts@0
Expand Down
2 changes: 1 addition & 1 deletion eng/testing/performance/ios_scenarios.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
</HelixWorkItem>
<HelixWorkItem Include="SOD - iOS HelloWorld $(RuntimeFlavor) Zip Size $(LlvmPath) $(SymbolsPath)">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<PreCommands>cd $(ScenarioDirectory)helloios;cp -v $HELIX_CORRELATION_PAYLOAD/iosHelloWorldZip/iOSSampleApp/iOSSampleApp.zip .;$(Python) pre.py --name iOSSampleApp.zip</PreCommands>
<PreCommands>cd $(ScenarioDirectory)helloios;cp -v $HELIX_CORRELATION_PAYLOAD/iosHelloWorldZip/iOSSampleApp.zip .;$(Python) pre.py --name iOSSampleApp.zip</PreCommands>
<Command>$(Python) test.py sod --scenario-name &quot;%(Identity)&quot;</Command>
<PostCommands>$(Python) post.py</PostCommands>
</HelixWorkItem>
Expand Down
2 changes: 2 additions & 0 deletions eng/testing/performance/performance-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,8 @@ fi
if [[ "$iosmono" == "true" || "$iosnativeaot" == "true" ]]; then
mkdir -p $payload_directory/iosHelloWorld && cp -rv $source_directory/iosHelloWorld $payload_directory/iosHelloWorld
mkdir -p $payload_directory/iosHelloWorldZip && cp -rv $source_directory/iosHelloWorldZip $payload_directory/iosHelloWorldZip

find "$payload_directory/iosHelloWorldZip/" -type f -name "*.zip" -execdir mv {} "$payload_directory/iosHelloWorldZip/iOSSampleApp.zip"
fi

ci=true
Expand Down