Skip to content

Conversation

@kotlarmilos
Copy link
Member

@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR adds optimized property to the sample app for AppleAppBuilder.

Fixes failing perf job https://dev.azure.com/dnceng/internal/_build/results?buildId=2243250&view=logs&j=3ed67216-8d06-57e4-e860-09ab51946aa1&t=ae27ed72-ed5a-5253-cbac-402a1b387446

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 9.0.0

@kotlarmilos
Copy link
Member Author

@ivanpovazan
Copy link
Member

In the perf job failure, it says: ##[warning]No file or directory found - /Users/runner/work/1/s/src/mono/sample/iOS-NativeAOT/bin/ios-arm64/Bundle/HelloiOS/Release-iphoneos/HelloiOS.app

If Optimized is not set, does that mean the build failed, or the bundle path is different in that case?

@kotlarmilos
Copy link
Member Author

If Optimized is not set, does that mean the build failed, or the bundle path is different in that case?

The bundle path is different in that case. If the optimized is not set, the bundle is always created in /Users/runner/work/1/s/src/mono/sample/iOS-NativeAOT/bin/ios-arm64/Bundle/HelloiOS/Debug-iphoneos/HelloiOS.app. Later, it was searched in ##[warning]No file or directory found - /Users/runner/work/1/s/src/mono/sample/iOS-NativeAOT/bin/ios-arm64/Bundle/HelloiOS/Release-iphoneos/HelloiOS.app.

@ivanpovazan
Copy link
Member

Thanks, so the search is hardcoded to look into Release-iphoneos, but the Optimized flag controls whether XCode will build for Debug or Release configuration?

@kotlarmilos
Copy link
Member Author

Correct. The app bundle is built in Release mode so it is expected to be in Release-iphoneos directory.

@kotlarmilos kotlarmilos merged commit 9a696fd into dotnet:main Aug 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
@kotlarmilos
Copy link
Member Author

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation Dec 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7103375049

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants