Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 5, 2023

Backport of #90585 to release/8.0-staging

/cc @kotlarmilos

Customer Impact

Issue dotnet/performance#3544 was opened by a team member.

This PR addresses an internal CI job that measures the performance of a sample Native AOT app on iOS. The change introduces a missing configuration property in the build process, ensuring that the app is created in the correct path. Without this change, there are no performance measurements for the Native AOT app on iOS, making it impossible to track performance improvements or regressions.

Fixes dotnet/performance#3544

Testing

The fix was tested on the main branch by executing the internal CI job.

Risk

Risk is low. It only affects the sample app used for performance measurements and does not involve any modifications to the runtime. Additionally, it does not impact the code shipped in a NuGet package.

@github-actions github-actions bot requested a review from marek-safar as a code owner December 5, 2023 16:06
@ghost ghost added the area-VM-meta-mono label Dec 5, 2023
@kotlarmilos kotlarmilos self-assigned this Dec 5, 2023
@kotlarmilos kotlarmilos added this to the 8.0.x milestone Dec 5, 2023
@kotlarmilos kotlarmilos added Servicing-consider Issue for next servicing release review os-ios Apple iOS labels Dec 5, 2023
@ghost
Copy link

ghost commented Dec 5, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90585 to release/8.0-staging

/cc @kotlarmilos

Customer Impact

Issue dotnet/performance#3544 was opened by a team member.

This PR addresses an internal CI job that measures the performance of a sample Native AOT app on iOS. The change introduces a missing configuration property in the build process, ensuring that the app is created in the correct path.

Fixes dotnet/performance#3544

Testing

The fix was tested on the main branch by executing the internal CI job.

Risk

Risk is low. It only affects the sample app used for performance measurements and does not involve any modifications to the runtime. Additionally, it does not impact the code shipped in a NuGet package.

Author: github-actions[bot]
Assignees: kotlarmilos
Labels:

Servicing-consider, area-VM-meta-mono, os-ios

Milestone: 8.0.x

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 5, 2023
@leecow leecow modified the milestones: 8.0.x, 8.0.2 Dec 5, 2023
@akoeplinger akoeplinger merged commit 97242c4 into release/8.0-staging Dec 6, 2023
@akoeplinger akoeplinger deleted the backport/pr-90585-to-release/8.0-staging branch December 6, 2023 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-meta-mono os-ios Apple iOS Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants