Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
2d1eafc
[DO NOT MERGE | REVERT] - Forced AV in brotli native code. Disable un…
carlossanlop Nov 7, 2023
5242ff3
gen-debug-dump-docs.py: More meaningful messages
carlossanlop Nov 7, 2023
070fd63
XUnitLogChecker.cs: Minor fixes
carlossanlop Nov 7, 2023
c178f37
CoreclrTestWrapperLib.cs: Avoid passing null coreRoot string to Path.…
carlossanlop Nov 7, 2023
ce72a2a
RunnerTemplate.cmd: Invoke XUnitLogChecker
carlossanlop Nov 7, 2023
a57ced6
RunnerTemplate.sh: Invoke XUnitLogChecker
carlossanlop Nov 7, 2023
6d04923
sendtohelix.proj: Set __TestArchitecture and build XUnitLogChecker
carlossanlop Nov 7, 2023
173911f
Fix cmd with a goto because delayed execution prevents setting variab…
carlossanlop Nov 7, 2023
9414c81
Minor sh improvements and verbosity additions
carlossanlop Nov 7, 2023
e4c94ac
Move to tests.proj
carlossanlop Nov 7, 2023
02db8bc
Move IsTargetOSSupportedByXUnitLogChecker to root Directory.Build.props.
carlossanlop Nov 8, 2023
fb616c5
Simplify project reference in tests.proj
carlossanlop Nov 8, 2023
6e077e6
Remove coredump_filter and ulimit configuration, since helix machines…
carlossanlop Nov 8, 2023
044cb20
Rename IsTargetOSSupportedByXUnitLogChecker to IsXUnitLogCheckerSuppo…
carlossanlop Nov 9, 2023
2732b61
Skip XUnitLogChecker execution in Net48 libraries test runs.
carlossanlop Nov 9, 2023
e07e28b
Re-add the accidentally removed HelixCorrelationPayload, but with the…
carlossanlop Nov 9, 2023
52df19c
Build XUnitLogChecker in tests.proj
carlossanlop Nov 9, 2023
c04a72a
Add an empty Tests target and a copy of ZipTestArchive to the XUnitLo…
carlossanlop Nov 9, 2023
b047c8c
Condition the custom ZipTestArchive inside XUnitLogChecker.csproj
carlossanlop Nov 9, 2023
8189449
Separate framework check from IsXUnitLogCheckerSupported, the value i…
carlossanlop Nov 9, 2023
3bd400f
Change cmd env var to int
carlossanlop Nov 9, 2023
0b5bd2a
typo typo typo
carlossanlop Nov 9, 2023
7123d0f
Separate the directory paths into two, they have different purposes.
carlossanlop Nov 9, 2023
384fdf5
Fix helix path
carlossanlop Nov 9, 2023
7c3d0fe
The zip goes under artifacts, not artifacts/bin
carlossanlop Nov 10, 2023
26db023
Skip in NativeAot tests
carlossanlop Nov 10, 2023
93e33c2
Always set the value of _IsXUnitLogCheckerSupported in the cmd and sh…
carlossanlop Nov 10, 2023
d3fe8fa
Add verbose messages for IsXUnitLogCeckerSupported possible values, a…
carlossanlop Nov 10, 2023
01541fc
Try disabling using TestNativeAot instead
carlossanlop Nov 10, 2023
cda54c1
Do not attempt to run libs.tests on XUnitLogChecker
carlossanlop Nov 10, 2023
ec0774b
Remove temp messages
carlossanlop Nov 10, 2023
2c9ec70
Better name for internal property in sendtohelix.proj
carlossanlop Nov 10, 2023
11fa84a
Temp var that prints literal value of IsXUnitLogCheckerSupported
carlossanlop Nov 10, 2023
c955c5e
Move the MSBuildProjectName condition to the RunTests target itself
carlossanlop Nov 10, 2023
dfa7985
Remove the test target from XUnitLogChecker.csproj
carlossanlop Nov 10, 2023
299a454
Set OutDir value directly
carlossanlop Nov 10, 2023
942687b
TEMP: Print value of property in send to helix
carlossanlop Nov 10, 2023
4c9a8ff
Put output directory somewhere else so we dont assume XUnitLogChecker…
carlossanlop Nov 10, 2023
6f609e9
Remove the undefined env var check in the cmd.
carlossanlop Nov 10, 2023
bf96801
Use BuildTargetFramework to set the env var in sendtohelixhelp.proj
carlossanlop Nov 10, 2023
ca3522e
Use NetCoreAppCurrent
carlossanlop Nov 10, 2023
0345424
Fix temp conflict with base
carlossanlop Nov 10, 2023
3ca551a
The Libraries Build leg needs to also publish the artifacts/bin/XUnit…
carlossanlop Nov 10, 2023
c417c25
Extra spacing
carlossanlop Nov 10, 2023
5c46f37
Only set envvars inside the condition
carlossanlop Nov 10, 2023
c2243dc
The cmd condition does not work unless double quoted
carlossanlop Nov 10, 2023
d94e151
TMP: Printed final value
carlossanlop Nov 10, 2023
75a4033
Add fi accidentally removed
carlossanlop Nov 10, 2023
d6da591
Move the Linux-only code to its own if, and everything else should ru…
carlossanlop Nov 10, 2023
6568293
Ensure the OSX core folder is also visited.
carlossanlop Nov 11, 2023
85b5e0b
Revert temporary changes
carlossanlop Nov 11, 2023
25f6a70
[DO NOT MERGE | REVERT] Cause a crash and disable unrelated CI legs
carlossanlop Nov 13, 2023
f7d7e50
Simplify envvar condition in sendtohelixhelp.proj
carlossanlop Nov 14, 2023
b926291
Move build target framework check up to the property group.
carlossanlop Nov 14, 2023
69df4b6
Missed a sh variable $
carlossanlop Nov 14, 2023
bb772dd
Remove should set variable from outside the condition, it's unused
carlossanlop Nov 14, 2023
3686646
In OSX, $HELIX_DUMP_FOLDER is passed as `/cores`, so we don't need to…
carlossanlop Nov 14, 2023
87f7055
Missed a ;
carlossanlop Nov 14, 2023
3da51fb
Another missed ;
carlossanlop Nov 14, 2023
0d15bf8
Use the $core_file_name when renaming the dmp
carlossanlop Nov 14, 2023
bcd2acf
Remove sleep
carlossanlop Nov 14, 2023
7857f36
Remove $RANDOM
carlossanlop Nov 15, 2023
fab3449
Revert the temporary crash and the disabled CI legs.
carlossanlop Nov 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gen-debug-dump-docs.py: More meaningful messages
  • Loading branch information
carlossanlop committed Nov 10, 2023
commit 5242ff3d8beb3dc64b9da57b33febf86f797bfbb
35 changes: 20 additions & 15 deletions eng/testing/gen-debug-dump-docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
import sys
import platform

scriptname = os.path.basename(__file__)

def print_detail(str):
print(f"{scriptname}: {str}")

build_id = ''
job_id = ''
workitem = ''
Expand All @@ -16,55 +21,55 @@
idx += 1
if arg == '-buildid':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -buildid")
print_detail("Must specify a value for -buildid")
exit(1)

build_id = sys.argv[idx]
idx += 1

if arg == '-jobid':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -jobid")
print_detail("Must specify a value for -jobid")
exit(1)

job_id = sys.argv[idx]
idx += 1

if arg == '-workitem':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -workitem")
print_detail("Must specify a value for -workitem")
exit(1)

workitem = sys.argv[idx]
idx += 1

if arg == '-templatedir':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -templatedir")
print_detail("Must specify a value for -templatedir")
exit(1)

template_dir = sys.argv[idx]
idx += 1

if arg == '-outdir':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -outdir")
print_detail("Must specify a value for -outdir")
exit(1)

out_dir = sys.argv[idx]
idx += 1

if arg == '-dumpdir':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -dumpdir")
print_detail("Must specify a value for -dumpdir")
exit(1)

dump_dir = sys.argv[idx]
idx += 1

if arg == '-productver':
if idx >= args_len or sys.argv[idx].startswith('-'):
print("Must specify a value for -productver")
print_detail("Must specify a value for -productver")
exit(1)

product_ver = sys.argv[idx]
Expand All @@ -77,23 +82,23 @@
dump_names.append(filename)

if len(dump_names) == 0:
print("Did not find dumps, skipping dump docs generation.")
print_detail("Did not find dumps, skipping dump docs generation.")
exit(0)

if build_id == '':
print("ERROR: unespecified required argument -buildid")
print_detail("ERROR: unespecified required argument -buildid")
exit(1)

if workitem == '':
print("ERROR: unespecified required argument -workitem")
print_detail("ERROR: unespecified required argument -workitem")
exit(1)

if job_id == '':
print("ERROR: unespecified required argument -jobid")
print_detail("ERROR: unespecified required argument -jobid")
exit(1)

if product_ver == '':
print("ERROR: unespecified required argument -productver")
print_detail("ERROR: unespecified required argument -productver")
exit(1)

replace_string = ''
Expand All @@ -104,7 +109,7 @@
with open(source_file, 'r') as f:
file_text = f.read()

print('read file: ' + source_file)
print_detail('read file: ' + source_file)

replace_string = file_text.replace('%JOBID%', job_id)
replace_string = replace_string.replace('%WORKITEM%', workitem)
Expand All @@ -115,7 +120,7 @@

output_file = out_dir + dir_separator + 'how-to-debug-dump.md'
with open(output_file, 'w+') as output:
print('writing output file: ' + output_file)
print_detail('writing output file: ' + output_file)

lines = replace_string.split(os.linesep)
lin_dump_dir= workitem + "/workitems/" + workitem + "/"
Expand All @@ -133,4 +138,4 @@
else:
output.write(line + os.linesep)

print('done writing debug dump information')
print_detail('done writing debug dump information')