Fix JsonArray.Add and ReplaceWith regressions. #94854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #94842. See #94842 (comment) for an analysis of the problem and proposed fix.
|
tarekgh
reviewed
Nov 16, 2023
tarekgh
reviewed
Nov 16, 2023
src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Nov 16, 2023
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
I added minor questions, otherwise LGTM.
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/6897349477 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #94842. See #94842 (comment) for an analysis of the problem and proposed fix. Should be backported to .NET 8.