Skip to content

Fix JsonArray.Add and ReplaceWith regressions. #94854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eiriktsarpalis merged 3 commits into from
Nov 16, 2023
Merged

Fix JsonArray.Add and ReplaceWith regressions. #94854

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96fc916
Fix JsonArray.Add and ReplaceWith regressions.
eiriktsarpalis Nov 16, 2023
97095ee
Add comment
eiriktsarpalis Nov 16, 2023
565d1b3
Address feedback.
eiriktsarpalis Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@eiriktsarpalis
eiriktsarpalis committed Nov 16, 2023
commit 97095eeaa9857f1e360633defa29f7fb155d56d8
5 changes: 5 additions & 0 deletions src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,11 @@ internal void AssignParent(JsonNode parent)
Parent = parent;
}

/// <summary>
/// Adaptation of the equivalent JsonValue.Create factory method extended
/// to support arbitrary <see cref="JsonElement"/> and <see cref="JsonNode"/> values.
/// TODO consider making public cf. https://github.com/dotnet/runtime/issues/70427
/// </summary>
[RequiresUnreferencedCode(JsonSerializer.SerializationUnreferencedCodeMessage)]
[RequiresDynamicCode(JsonSerializer.SerializationRequiresDynamicCodeMessage)]
internal static JsonNode? ConvertFromValue<T>(T? value, JsonNodeOptions? options = null)
Expand Down