[release/8.0-staging] Fix missing symbols for mono-aot-cross #95505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
akoeplinger
force-pushed
the
backport/pr-95504-to-release/8.0-staging
branch
from
d87c677 to
d6aea1c
Compare
lambdageek
approved these changes
Dec 1, 2023
With #83903 the path to the .pdb symbol file changed to include a `PDB` subdirectory. We didn't adjust the path in mono.proj and didn't notice it because of an `Exists()` check that made this a no-op. While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms. Fix the path and added the missing non-Windows symbols
akoeplinger
force-pushed
the
backport/pr-95504-to-release/8.0-staging
branch
from
d6aea1c to
9647ab3
Compare
akoeplinger
changed the title
These files are split out from the main .nupkg so they won't exist there which causes issues when nuget tries to apply the permissions during workload install.
Member
|
This was approved by tactics via email. |
akoeplinger
added
Servicing-approved
We were appending ExeSuffix on Windows so we looked for mono-aot-cross.exe.pdb instead of mono-aot-cross.pdb
akoeplinger
force-pushed
the
backport/pr-95504-to-release/8.0-staging
branch
from
88aee16 to
8784a54
Compare
3 tasks
Member
|
Timeout failure is unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95504 to release/8.0-staging
/cc @akoeplinger
Customer Impact
With #83903 the path to the .pdb symbol file changed to include a
PDBsubdirectory. We didn't adjust the path in mono.proj and didn't notice it because of anExists()check that made this a no-op.This caused the .pdb file to not be uploaded to symbol servers which results in a failing VS APIScan check:
While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms.
Fix the path and added the missing non-Windows symbols.
This is a regression compared to 7.0.
Testing
Manually inspected the generated .symbols.nupkg and verified the .pdb is there.
Risk
Low.