Fix missing symbols for mono-aot-cross #95504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7059400157 |
akoeplinger
force-pushed
the
fix-mono-aot-cross-pdb
branch
from
e9786c8 to
93f9942
Compare
steveisok
approved these changes
Dec 1, 2023
directhex
approved these changes
Dec 1, 2023
With dotnet#83903 the path to the .pdb symbol file changed to include a `PDB` subdirectory. We didn't adjust the path in mono.proj and didn't notice it because of an `Exists()` check that made this a no-op. This caused the .pdb file to not be uploaded to symbol servers which results in a failing VS APIScan check. While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms. Fix the path and added the missing non-Windows symbols
akoeplinger
force-pushed
the
fix-mono-aot-cross-pdb
branch
from
93f9942 to
28992c2
Compare
akoeplinger
changed the title
lewing
pushed a commit
that referenced
this pull request
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #83903 the path to the .pdb symbol file changed to include a
PDBsubdirectory.We didn't adjust the path in mono.proj and didn't notice it because of an
Exists()check that made this a no-op.This caused the .pdb file to not be uploaded to symbol servers which results in a failing VS APIScan check:
While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms.
Fix the path and added the missing non-Windows symbols