Fix missing symbols for mono-aot-cross (take 2) #95577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With dotnet#83903 the path to the .pdb symbol file changed to include a `PDB` subdirectory. We didn't adjust the path in mono.proj and didn't notice it because of an `Exists()` check that made this a no-op. While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms. Fix the path and added the missing non-Windows symbols
ghost
added
the
akoeplinger
requested review from
directhex,
radical and
steveisok
and removed request for
marek-safar
These files are split out from the main .nupkg so they won't exist there which causes issues when nuget tries to apply the permissions during workload install.
akoeplinger
force-pushed
the
fix-symbols-mono-aot-cross
branch
from
d6eff54 to
a2f0be5
Compare
directhex
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is take 2 on #95504 which had to be reverted because it broke WasmBuildTests.
The reason is that we were including the .dbg/.dwarf files when generating UnixFilePermissions.xml and they were not there anymore because symbols are split out from the main .nupkg.
With #83903 the path to the .pdb symbol file changed to include a
PDBsubdirectory.We didn't adjust the path in mono.proj and didn't notice it because of an
Exists()check that made this a no-op.This caused the .pdb file to not be uploaded to symbol servers which results in a failing VS APIScan check:
While doing this I noticed we were also not including the .dwarf/.dbg symbols for non-Windows platforms.
Fix the path and added the missing non-Windows symbols