[release/8.0-staging] Use a sorted module order for metadata generation

src/coreclr/tools/Common/TypeSystem/Sorting/TypeSystemComparer.cs

@@ -25,7 +25,7 @@ namespace Internal.TypeSystem
     // to sort itself with respect to other instances of the same type.
     // Comparisons between different categories of types are centralized to a single location that
     // can provide rules to sort them.
-    public class TypeSystemComparer : IComparer<TypeDesc>, IComparer<MethodDesc>, IComparer<FieldDesc>, IComparer<MethodSignature>
+    public class TypeSystemComparer : IComparer<TypeDesc>, IComparer<MethodDesc>, IComparer<FieldDesc>, IComparer<MethodSignature>, IComparer<ModuleDesc>
     {
         public static TypeSystemComparer Instance { get; } = new TypeSystemComparer();
 
@@ -128,5 +128,10 @@ public int Compare(MethodSignature x, MethodSignature y)
         {
             return x.CompareTo(y, this);
         }
+
+        public int Compare(ModuleDesc x, ModuleDesc y)
+        {
+            return Compare(x.GetGlobalModuleType(), y.GetGlobalModuleType());
+        }
     }
 }

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/UsageBasedMetadataManager.cs

@@ -50,7 +50,7 @@ private static (string AttributeName, DiagnosticId Id)[] _requiresAttributeMisma
             };
 
         private readonly List<TypeDesc> _typesWithForcedEEType = new List<TypeDesc>();
-        private readonly List<ModuleDesc> _modulesWithMetadata = new List<ModuleDesc>();
+        private readonly SortedSet<ModuleDesc> _modulesWithMetadata = new SortedSet<ModuleDesc>(CompilerComparer.Instance);
         private readonly List<FieldDesc> _fieldsWithMetadata = new List<FieldDesc>();
         private readonly List<MethodDesc> _methodsWithMetadata = new List<MethodDesc>();
         private readonly List<MetadataType> _typesWithMetadata = new List<MetadataType>();