Fix fast-path support for ignoring nullable value types #96639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #96404. Should be backported to .NET 8.
|
eiriktsarpalis
commented
Jan 8, 2024
| IsValueType = type.IsValueType; | ||
| TypeKind = type.TypeKind; | ||
| SpecialType = type.SpecialType; | ||
| SpecialType = type.OriginalDefinition.SpecialType; |
Member
Author
There was a problem hiding this comment.
The root cause of the issue is that only the generic type definition of Nullable<T> is reported as SpecialType.System_Nullable_T resulting in the CanBeNull property in line 36 of this file to report incorrect values.
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/7460781523 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #96404. Should be backported to .NET 8.