-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[release/8.0-staging] Fix fast-path support for ignoring nullable value types #96669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Fix fast-path support for ignoring nullable value types #96669
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #96639 to release/8.0 /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@eiriktsarpalis does S.T.J library need service authoring? |
|
I checked and it seems the relevant properties are already set in the project. I think it's because we skipped servicing last month. cc @carlossanlop |
|
Yes, S.T.J needs its version bumped to 2 for this change. |
|
Approved over email. |
Backport of #96639 to release/8.0-staging
/cc @eiriktsarpalis
Customer Impact
According to a customer-reported issue, .NET 8 regressed handling of
JsonIgnoreCondition.WhenWritingNullconfiguration when applied toNullable<T>properties, specifically for the case of the fast-path source generator. Users should still be able to work around the issue by switching to the metadata-based source generator, at the cost of serialization performance.Testing
Added regression tests and enabled a number of tests that were only being run against the reflection-based serializer until today.
Risk
Low. Fix is targeted one-liner change addressing the issue in question.