Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2024

Backport of #96639 to release/8.0-staging

/cc @eiriktsarpalis

Customer Impact

According to a customer-reported issue, .NET 8 regressed handling of JsonIgnoreCondition.WhenWritingNull configuration when applied to Nullable<T> properties, specifically for the case of the fast-path source generator. Users should still be able to work around the issue by switching to the metadata-based source generator, at the cost of serialization performance.

Testing

Added regression tests and enabled a number of tests that were only being run against the reflection-based serializer until today.

Risk

Low. Fix is targeted one-liner change addressing the issue in question.

@ghost ghost added the area-System.Text.Json label Jan 9, 2024
@ghost
Copy link

ghost commented Jan 9, 2024

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #96639 to release/8.0

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@eiriktsarpalis eiriktsarpalis changed the base branch from release/8.0 to release/8.0-staging January 9, 2024 12:15
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Jan 9, 2024
@eiriktsarpalis eiriktsarpalis self-assigned this Jan 9, 2024
@eiriktsarpalis eiriktsarpalis added this to the 8.0.x milestone Jan 9, 2024
@eiriktsarpalis eiriktsarpalis changed the title [release/8.0] Fix fast-path support for ignoring nullable value types [release/8.0-staging] Fix fast-path support for ignoring nullable value types Jan 9, 2024
@tarekgh
Copy link
Member

tarekgh commented Jan 9, 2024

@eiriktsarpalis does S.T.J library need service authoring?

@eiriktsarpalis
Copy link
Member

I checked and it seems the relevant properties are already set in the project. I think it's because we skipped servicing last month. cc @carlossanlop

@carlossanlop
Copy link
Contributor

Yes, S.T.J needs its version bumped to 2 for this change.

@eiriktsarpalis eiriktsarpalis added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 10, 2024
@eiriktsarpalis
Copy link
Member

Approved over email.

@eiriktsarpalis eiriktsarpalis deleted the backport/pr-96639-to-release/8.0 branch January 11, 2024 13:27
@akoeplinger akoeplinger modified the milestones: 8.0.x, 8.0.2 Jan 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.Json Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants