Skip to content

[release/8.0][mono][debugger] Debugger improvements on .net8 #97160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaystg merged 6 commits into from
Jan 24, 2024
Merged

[release/8.0][mono][debugger] Debugger improvements on .net8 #97160

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
725e0f8
[mono][hotreload] Generate seq_points if we don't have pdb informatio…
thaystg Oct 6, 2023
77a3613
Fix CMD_OBJECT_REF_GET_VALUES_BY_FIELD_TOKEN behavior (#93363)
thaystg Oct 16, 2023
3d1d2b0
[mono] Simplify of OffsetToStringData as it's done on coreclr (#93987)
thaystg Oct 26, 2023
dae8eb0
[mono] Trying to fix performance regression. (#94358)
thaystg Nov 6, 2023
9d45e3d
[mono][debugger] Improve debugger features (#94066)
thaystg Nov 22, 2023
3bcb26f
Bump protocol version to check if we are in correct version that has …
thaystg Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CMD_OBJECT_REF_GET_VALUES_BY_FIELD_TOKEN behavior (#93363)
  • Loading branch information
@thaystg
thaystg committed Jan 18, 2024
commit 77a3613dd1bb386fb53082a46bbd1babd7e5670e
14 changes: 11 additions & 3 deletions src/mono/mono/component/debugger-agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10385,13 +10385,21 @@ object_commands (int command, guint8 *p, guint8 *end, Buffer *buf)
case CMD_OBJECT_REF_GET_VALUES_BY_FIELD_TOKEN: {
len = 1;
i = 0;
MonoClass* klass = decode_typeid (p, &p, end, NULL, &err);
int class_token = decode_int (p, &p, end);
int field_token = decode_int (p, &p, end);
gpointer iter = NULL;

while ((f = mono_class_get_fields_internal (klass, &iter))) {
if (mono_class_get_field_token (f) == field_token)
for (k = obj_type; k; k = m_class_get_parent (k)) {
if (m_class_get_type_token (k) == class_token) {
break;
}
}
if (!k)
goto invalid_fieldid;
while ((f = mono_class_get_fields_internal (k, &iter))) {
if (mono_class_get_field_token (f) == field_token) {
goto get_field_value;
}
}
goto invalid_fieldid;
}
Expand Down