[release/8.0][mono][debugger] Debugger improvements on .net8 #97160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from HotReload (dotnet#93039) * Generating seq_points if we don't have pdb information from HotReload * Apply suggestions from code review Co-authored-by: Aleksey Kliger (λgeek) <[email protected]> * Addressing @lambdageek comments --------- Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
…#93987) * Change implementation of OffsetToStringData as it's done on coreclr * Fix comment * Remove more comments * completely remove the comments * Update RuntimeHelpers.Mono.cs * Addressing comments * Addressing @lambdageek comment.
* Trying to fix performance regression. * Fix performance issue
* Creating new messages, changing some olds, and fixing when jit_end is called while running a invoke_method * Fix compilation error * Fix compilation * Applying suggestions from @lambdageek and adding more changes. * Addressing @lambdageek suggestions. * Addressing @lambdageek comment * Addressing @lambdageek comments * adding mono_component_api to function added.
ghost
added
the
thaystg
changed the title
2 tasks
…all the things to make icordebug work. (dotnet#97161)
thaystg
requested review from
BrzVlad,
SamMonoRT,
kotlarmilos,
lambdageek,
marek-safar and
vargaz
as code owners
lewing
approved these changes
Jan 19, 2024
lambdageek
approved these changes
Jan 19, 2024
jeffschwMSFT
approved these changes
Jan 19, 2024
thaystg
added
Servicing-approved
Member
Author
|
Approved by email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of these PR's:
#93039
#93363
#93987
#94358
#94066
Customer Impact
This backport is necessary to make possible to use mono iCorDebug to debug apps running on mono runtime in .net8.
Testing
Manually tested.
Risk
Medium. The changes are mainly located in debugger sources and are protected with
is using icordebugcheck. The other changes are already in .net9 for some time and didn't cause any known issue.