Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Jan 18, 2024

Bump protocol version to check if we are in correct version that has all the things to make icordebug work.

@thaystg thaystg requested a review from lambdageek January 18, 2024 16:35
@thaystg thaystg requested a review from marek-safar as a code owner January 18, 2024 16:35
@ghost ghost added the area-Debugger-mono label Jan 18, 2024
@ghost ghost assigned thaystg Jan 18, 2024
@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Bump protocol version to check if we are in correct version that has all the things to make icordebug work.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Jan 18, 2024

@lambdageek can you please approve this one, I would like to get this merged before the preview 1 of .net9.
I will also backport to .net8 this protocol bump.

@thaystg thaystg merged commit b8d78b7 into dotnet:main Jan 18, 2024
thaystg added a commit to thaystg/runtime that referenced this pull request Jan 18, 2024
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
thaystg added a commit that referenced this pull request Jan 24, 2024
* [mono][hotreload] Generate seq_points if we don't have pdb information from HotReload (#93039)

* Generating seq_points if we don't have pdb information from HotReload

* Apply suggestions from code review

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>

* Addressing @lambdageek comments

---------

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>

* Fix CMD_OBJECT_REF_GET_VALUES_BY_FIELD_TOKEN behavior (#93363)

* [mono] Simplify of OffsetToStringData as it's done on coreclr (#93987)

* Change implementation of OffsetToStringData as it's done on coreclr

* Fix comment

* Remove more comments

* completely remove the comments

* Update RuntimeHelpers.Mono.cs

* Addressing comments

* Addressing @lambdageek comment.

* [mono] Trying to fix performance regression. (#94358)

* Trying to fix performance regression.

* Fix performance issue

* [mono][debugger] Improve debugger features (#94066)

* Creating new messages, changing some olds, and fixing when jit_end is called while running a invoke_method

* Fix compilation error

* Fix compilation

* Applying suggestions from @lambdageek and adding more changes.

* Addressing @lambdageek suggestions.

* Addressing @lambdageek comment

* Addressing @lambdageek comments

* adding mono_component_api to function added.

* Bump protocol version to check if we are in correct version that has all the things to make icordebug work. (#97161)

---------

Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants