Skip to content

Add additionalSize for the DisableOptData #97476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikelle-rogers merged 3 commits into from
Jan 26, 2024
Merged

Add additionalSize for the DisableOptData #97476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd11967
add additionalSize for the DisableOptData
mikelle-rogers Jan 24, 2024
80e9dd6
adding STRESS_LOG0
mikelle-rogers Jan 24, 2024
d5d8a5a
adding STRESS_LOG
mikelle-rogers Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/debug/shared/dbgtransportsession.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2499,6 +2499,8 @@ DWORD DbgTransportSession::GetEventSize(DebuggerIPCEvent *pEvent)
break;

case DB_IPCE_DISABLE_OPTS:
cbAdditionalSize = sizeof(pEvent->DisableOptData);
break;

default:
printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK));
Copy link
Contributor

@davmason davmason Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to a stress log too?

Copy link
Member

@hoyosjs hoyosjs Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also turn this into a stress log statement too?

Copy link
Member

@hoyosjs hoyosjs Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK));
STRESS_LOG1("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK));

Expand Down