Add additionalSize for the DisableOptData #97476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsAdd additional size to the buffer to read DisableOptData from memory before passing the IPCEvent.
|
davmason
reviewed
Jan 24, 2024
| break; | ||
|
|
||
| default: | ||
| printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK)); |
Contributor
There was a problem hiding this comment.
Can you change this to a stress log too?
hoyosjs
approved these changes
Jan 24, 2024
| break; | ||
|
|
||
| default: | ||
| printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK)); |
Member
There was a problem hiding this comment.
Can you please also turn this into a stress log statement too?
hoyosjs
reviewed
Jan 24, 2024
| break; | ||
|
|
||
| default: | ||
| printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK)); |
Member
There was a problem hiding this comment.
Suggested change
| printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK)); | |
| STRESS_LOG1("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK)); |
hoyosjs
requested changes
Jan 24, 2024
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
hoyosjs
approved these changes
Jan 24, 2024
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7647065981 |
4 tasks
This was referenced Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional size to the buffer to read DisableOptData from memory before passing the IPCEvent.