Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 24, 2024

Backport of #97476 to release/8.0-staging

/cc @hoyosjs @mikelle-rogers

Customer Impact

  • Customer reported
  • Found internally

When debugging on Linux and Mac a specific sequence of commands can lead to a crash of the target process. With this fix, the buffers will be given enough memory for the IPC to access the information needed for optimization commands.

Regression

  • Yes
  • No

This call was added as a default to many debugging scenarios. This crashes the runtime on otherwise working debugging sessions.

Testing

Manual validation performed on reported scenario. Unit test added on the diagnostic side.

Risk

Low - follows pattern of all other commands to adjust buffer size appropriately.

@ghost
Copy link

ghost commented Jan 24, 2024

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #97476 to release/8.0-staging

/cc @hoyosjs @mikelle-rogers

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@mikelle-rogers mikelle-rogers self-assigned this Jan 24, 2024
@hoyosjs hoyosjs added the Servicing-consider Issue for next servicing release review label Jan 24, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@rbhanda rbhanda added this to the 8.0.3 milestone Jan 25, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 25, 2024
@mikelle-rogers mikelle-rogers merged commit d7a4118 into release/8.0-staging Jan 26, 2024
@hoyosjs hoyosjs deleted the backport/pr-97476-to-release/8.0-staging branch January 26, 2024 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants