Skip to content

[NativeAOT] Inline TLS access for linux/arm64 #97910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 24 commits into from
Feb 15, 2024
Merged

[NativeAOT] Inline TLS access for linux/arm64 #97910

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
936faff
wip
kunalspathak Jan 31, 2024
531ec41
hacky version
kunalspathak Feb 1, 2024
85b3c98
more fix
kunalspathak Feb 1, 2024
d5d2aa6
missing build error
kunalspathak Feb 1, 2024
ea4b214
wip
kunalspathak Feb 1, 2024
db02c45
fixes
kunalspathak Feb 1, 2024
349167b
fix
kunalspathak Feb 1, 2024
da88ed4
Add IMAGE_REL_AARCH64_TLSDESC_CALL
kunalspathak Feb 2, 2024
70d53bd
Use GT_CALL to emit everything
kunalspathak Feb 2, 2024
3edff40
fix the loading of slow helper
kunalspathak Feb 2, 2024
4c927e2
fix build error
kunalspathak Feb 2, 2024
9daf11e
adjust the endif
kunalspathak Feb 2, 2024
9830590
fix the slow helper relocation
kunalspathak Feb 2, 2024
259df0b
cleanup
kunalspathak Feb 2, 2024
7de3d03
fix iiaAddr() for TLS, add IsTlsIconHandle()
kunalspathak Feb 2, 2024
adf64f5
add comments
kunalspathak Feb 2, 2024
4e3bad8
jit format
kunalspathak Feb 2, 2024
92f4eb6
Remove EmitInlineTLSAccess()
kunalspathak Feb 2, 2024
6916004
Merge remote-tracking branch 'origin/main' into nativeaot-tls-linux-a…
kunalspathak Feb 3, 2024
19de2ae
update guid
kunalspathak Feb 3, 2024
1bc76ce
fix for sharedlibrary
kunalspathak Feb 6, 2024
2e0a7f4
misc changes
kunalspathak Feb 6, 2024
b7a43f9
Review feedback
kunalspathak Feb 12, 2024
8af209f
Merge remote-tracking branch 'origin/main' into nativeaot-tls-linux-a…
kunalspathak Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
@kunalspathak
kunalspathak committed Feb 1, 2024
commit db02c45dbfd04b65659cc7f76dbbacf7529a99b0
2 changes: 1 addition & 1 deletion src/coreclr/jit/codegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2342,7 +2342,7 @@ void CodeGen::genSetRegToConst(regNumber targetReg, var_types targetType, GenTre
else
{
attr = EA_SET_FLG(attr, EA_CNS_TLSGD_RELOC);
GetEmitter()->emitIns_R_R_I(INS_ldr, attr, tree->GetReg(), REG_R0, tree->AsIntCon()->gtIconVal);
GetEmitter()->emitIns_R_R_I(INS_ldr, attr, tree->GetRegNum(), REG_R0, tree->AsIntCon()->gtIconVal);
//GetEmitter()->emitInsLoadStoreOp(INS_lea, attr, targetReg, tree);
}
break;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/emitarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16158,7 +16158,7 @@ size_t emitter::emitOutputInstr(insGroup* ig, instrDesc* id, BYTE** dp)
dst += emitOutput_Instr(dst, code);
if (id->idIsTlsGD() && id->idIsLargeCns())
{
emitRecordRelocation(odst, (void*)emitGetInsSC(id), IMAGE_REL_AARCH64_TLSDESC_LD64_LO12);
emitRecordRelocation(dst, (void*)emitGetInsSC(id), IMAGE_REL_AARCH64_TLSDESC_LD64_LO12);
}
break;

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tools/Common/Compiler/DependencyAnalysis/Relocation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ public static unsafe long ReadValue(RelocType relocType, void* location)
case RelocType.IMAGE_REL_TPOFF:
case RelocType.IMAGE_REL_FILE_ABSOLUTE:
case RelocType.IMAGE_REL_SYMBOL_SIZE:
case RelocType.IMAGE_REL_AARCH64_TLSDESC_LD64_LO12:
return *(int*)location;
case RelocType.IMAGE_REL_BASED_DIR64:
return *(long*)location;
Expand All @@ -553,7 +554,6 @@ public static unsafe long ReadValue(RelocType relocType, void* location)
return GetArm64Rel21((uint*)location);
case RelocType.IMAGE_REL_BASED_ARM64_PAGEOFFSET_12A:
return GetArm64Rel12((uint*)location);
case RelocType.IMAGE_REL_AARCH64_TLSDESC_LD64_LO12:
case RelocType.IMAGE_REL_AARCH64_TLSDESC_ADD_LO12:
case RelocType.IMAGE_REL_AARCH64_TLSLE_ADD_TPREL_HI12:
case RelocType.IMAGE_REL_AARCH64_TLSLE_ADD_TPREL_LO12_NC:
Expand Down