Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
e24179e
[release/8.0-staging] [browser] Use whole assembly name when looking …
maraf Jan 19, 2024
5e9e29f
[release/8.0][browser] BrowserWebSocket.ReceiveAsync after server ini…
pavelsavara Jan 23, 2024
fe443a9
[release/8.0][mono][debugger] Debugger improvements on .net8 (#97160)
thaystg Jan 24, 2024
d7a4118
[release/8.0-staging] Add additionalSize for the DisableOptData (#97479)
github-actions[bot] Jan 26, 2024
1901707
[release/8.0-staging] Bump to new Ubuntu 22.04 queue for PPC64 (#97555)
github-actions[bot] Jan 26, 2024
b54886b
[release/8.0-staging] Fix compilation error with generic type attribu…
github-actions[bot] Jan 31, 2024
e6d8079
Remove use of NewHolder as field. (#97843)
github-actions[bot] Feb 6, 2024
b0025c7
[release/8.0-staging] Update dependencies from dotnet/runtime-assets …
dotnet-maestro[bot] Feb 7, 2024
d8042d4
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
dotnet-maestro[bot] Feb 7, 2024
c2415d7
[release/8.0] Fix STJ SG regression in handling of property names tha…
eiriktsarpalis Feb 8, 2024
2663ba6
Update SystemDataSqlClientVersion from 4.8.5 -> 4.8.6 for component g…
github-actions[bot] Feb 8, 2024
d62ff0b
Disable jiterpreter_do_jit_call to address issues with disabling Wasm…
kg Feb 8, 2024
53c1d13
Fixes exception while debugging on Chrome as IDE (#97871)
github-actions[bot] Feb 9, 2024
ea2b2e8
Backport #97418 (#97568)
thaystg Feb 9, 2024
279fe23
Update dependencies from https://github.com/dotnet/runtime-assets bui…
dotnet-maestro[bot] Feb 9, 2024
eded9a5
[release/8.0-staging] Ensure that the Create(Dot(...)) optimization d…
github-actions[bot] Feb 9, 2024
a143568
Don't clean up thread list on shutdown (#97188)
github-actions[bot] Feb 9, 2024
2767a15
[mono][interp] Fix inlining of ldarga (#97650)
BrzVlad Feb 9, 2024
ef1b0d6
[release/8.0-staging] [mono][jit] Fix passing of byref arguments in m…
vargaz Feb 9, 2024
4b040aa
Stop trying to format HOST_RUNTIME_CONTRACT property with locale sett…
elinor-fung Feb 9, 2024
6cd0edd
Backport of Handle open types to appear in interface maps (#97733) to…
davidwrighton Feb 9, 2024
c804f58
[release/8.0-staging] Move a lock to protect m_pDynamicStaticsInfo (#…
github-actions[bot] Feb 9, 2024
f4075f3
Ensure that constant folding for SIMD shifts on xarch follow the corr…
tannergooding Feb 10, 2024
d45a576
[release/8.0-staging] Ensure that the various `Max*Number` and `Min*N…
github-actions[bot] Feb 10, 2024
ff4e048
Define installer-owned directories (#98241)
github-actions[bot] Feb 11, 2024
2190e9b
Fix Windows implementation of NegotiateAuthenticationPal.GetMIC (#98031)
filipnavara Feb 12, 2024
dedae5e
[release/8.0-staging] Fix constant folding for arm64 MultiplyByScalar…
jakobbotsch Feb 12, 2024
bb540a8
[NativeAOT][8.0] Use ld_classic in ILC build and in build integration…
VSadov Feb 12, 2024
ba68cf1
Fix side effect of only not sending assembly_load while invoking meth…
github-actions[bot] Feb 12, 2024
6dec8dd
Fix polluted CompareState when comparing element types in a signature…
elinor-fung Feb 12, 2024
9598872
[release/8.0-staging] Update dependencies from dotnet/emsdk (#97405)
dotnet-maestro[bot] Feb 12, 2024
11ae42b
[release/8.0-staging] Fix regex lazy loop handling of backtracking st…
github-actions[bot] Feb 12, 2024
b7fda9f
Add ca-certificates to Mariner 2.0 deps (#98267)
github-actions[bot] Feb 12, 2024
00c95a6
[release/8.0-staging] Ensure that Vector512 uses the same patterns as…
github-actions[bot] Feb 12, 2024
c192fba
[release/8.0-staging] Implement faster RSA key check
github-actions[bot] Feb 12, 2024
11a4ff1
[release/8.0-staging] ServiceKey comparisons use Equals for matching …
github-actions[bot] Feb 12, 2024
ec1636f
Merge branch 'release/8.0' into release/8.0-staging
carlossanlop Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<clear />
<!--Begin: Package sources managed by Dependency Flow automation. Do not edit the sources below.-->
<!-- Begin: Package sources from dotnet-emsdk -->
<add key="darc-pub-dotnet-emsdk-9a29abd" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-9a29abdd/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-2fc2ffd" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-2fc2ffd9/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-201f4da" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-201f4dae/nuget/v3/index.json" />
<add key="darc-pub-dotnet-emsdk-201f4da-3" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-201f4dae-3/nuget/v3/index.json" />
Expand Down
68 changes: 34 additions & 34 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@
<Sha>45dd3a73dd5b64b010c4251303b3664bb30df029</Sha>
<SourceBuild RepoName="cecil" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100" Version="8.0.2">
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100" Version="8.0.3">
<Uri>https://github.com/dotnet/emsdk</Uri>
<Sha>2fc2ffd960930318f33fcaa690cbdbc55d72f52d</Sha>
<Sha>9a29abdd764a4de0f253ed368871877a47725247</Sha>
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.emsdk" Version="8.0.2-servicing.24062.1">
<Dependency Name="Microsoft.SourceBuild.Intermediate.emsdk" Version="8.0.3-servicing.24108.3">
<Uri>https://github.com/dotnet/emsdk</Uri>
<Sha>2fc2ffd960930318f33fcaa690cbdbc55d72f52d</Sha>
<Sha>9a29abdd764a4de0f253ed368871877a47725247</Sha>
<SourceBuild RepoName="emsdk" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="8.0.0-alpha.1.24061.1">
Expand Down Expand Up @@ -185,57 +185,57 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>61ae141d2bf3534619265c8f691fd55dc3e75147</Sha>
</Dependency>
<Dependency Name="System.ComponentModel.TypeConverter.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.ComponentModel.TypeConverter.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Data.Common.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Data.Common.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Drawing.Common.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Drawing.Common.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Formats.Tar.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Formats.Tar.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.IO.Compression.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.IO.Compression.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.IO.Packaging.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.IO.Packaging.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Net.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Net.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Private.Runtime.UnicodeData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Private.Runtime.UnicodeData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Runtime.TimeZoneData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Runtime.TimeZoneData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Security.Cryptography.X509Certificates.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Security.Cryptography.X509Certificates.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Text.RegularExpressions.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Text.RegularExpressions.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="System.Windows.Extensions.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Windows.Extensions.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.CilStrip.Sources" Version="8.0.0-beta.24060.2">
<Dependency Name="Microsoft.DotNet.CilStrip.Sources" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk" Version="16.0.5-alpha.1.23566.1" CoherentParentDependency="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100">
<Uri>https://github.com/dotnet/llvm-project</Uri>
Expand Down Expand Up @@ -354,13 +354,13 @@
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-optimization</Uri>
<Sha>67613417f5e1af250e6ddfba79f8f2885d8e90fb</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.HotReload.Utils.Generator.BuildTool" Version="8.0.0-alpha.0.24060.1">
<Dependency Name="Microsoft.DotNet.HotReload.Utils.Generator.BuildTool" Version="8.0.0-alpha.0.24072.2">
<Uri>https://github.com/dotnet/hotreload-utils</Uri>
<Sha>3b7da338c73b31b943c5512dcf0e2f6dd75f601c</Sha>
<Sha>bc857c64c5c5f1fc73048261e8f471c3310224d2</Sha>
</Dependency>
<Dependency Name="System.Runtime.Numerics.TestData" Version="8.0.0-beta.24060.2">
<Dependency Name="System.Runtime.Numerics.TestData" Version="8.0.0-beta.24108.4">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
<Sha>3b165c269b12cc194f48fde6a1a7694bece8931b</Sha>
<Sha>ca6c46012f68934198ce0d303196c3ae179230f5</Sha>
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.8.0-7.23566.2">
<Uri>https://github.com/dotnet/roslyn</Uri>
Expand Down
34 changes: 17 additions & 17 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion>
<SystemComponentModelAnnotationsVersion>5.0.0</SystemComponentModelAnnotationsVersion>
<SystemDataSqlClientVersion>4.8.5</SystemDataSqlClientVersion>
<SystemDataSqlClientVersion>4.8.6</SystemDataSqlClientVersion>
<SystemDrawingCommonVersion>8.0.0</SystemDrawingCommonVersion>
<SystemIOFileSystemAccessControlVersion>5.0.0</SystemIOFileSystemAccessControlVersion>
<SystemMemoryVersion>4.5.5</SystemMemoryVersion>
Expand All @@ -143,20 +143,20 @@
<SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
<runtimenativeSystemIOPortsVersion>8.0.0-rc.1.23406.6</runtimenativeSystemIOPortsVersion>
<!-- Runtime-Assets dependencies -->
<SystemRuntimeNumericsTestDataVersion>8.0.0-beta.24060.2</SystemRuntimeNumericsTestDataVersion>
<SystemComponentModelTypeConverterTestDataVersion>8.0.0-beta.24060.2</SystemComponentModelTypeConverterTestDataVersion>
<SystemDataCommonTestDataVersion>8.0.0-beta.24060.2</SystemDataCommonTestDataVersion>
<SystemDrawingCommonTestDataVersion>8.0.0-beta.24060.2</SystemDrawingCommonTestDataVersion>
<SystemFormatsTarTestDataVersion>8.0.0-beta.24060.2</SystemFormatsTarTestDataVersion>
<SystemIOCompressionTestDataVersion>8.0.0-beta.24060.2</SystemIOCompressionTestDataVersion>
<SystemIOPackagingTestDataVersion>8.0.0-beta.24060.2</SystemIOPackagingTestDataVersion>
<SystemNetTestDataVersion>8.0.0-beta.24060.2</SystemNetTestDataVersion>
<SystemPrivateRuntimeUnicodeDataVersion>8.0.0-beta.24060.2</SystemPrivateRuntimeUnicodeDataVersion>
<SystemRuntimeTimeZoneDataVersion>8.0.0-beta.24060.2</SystemRuntimeTimeZoneDataVersion>
<SystemSecurityCryptographyX509CertificatesTestDataVersion>8.0.0-beta.24060.2</SystemSecurityCryptographyX509CertificatesTestDataVersion>
<SystemTextRegularExpressionsTestDataVersion>8.0.0-beta.24060.2</SystemTextRegularExpressionsTestDataVersion>
<SystemWindowsExtensionsTestDataVersion>8.0.0-beta.24060.2</SystemWindowsExtensionsTestDataVersion>
<MicrosoftDotNetCilStripSourcesVersion>8.0.0-beta.24060.2</MicrosoftDotNetCilStripSourcesVersion>
<SystemRuntimeNumericsTestDataVersion>8.0.0-beta.24108.4</SystemRuntimeNumericsTestDataVersion>
<SystemComponentModelTypeConverterTestDataVersion>8.0.0-beta.24108.4</SystemComponentModelTypeConverterTestDataVersion>
<SystemDataCommonTestDataVersion>8.0.0-beta.24108.4</SystemDataCommonTestDataVersion>
<SystemDrawingCommonTestDataVersion>8.0.0-beta.24108.4</SystemDrawingCommonTestDataVersion>
<SystemFormatsTarTestDataVersion>8.0.0-beta.24108.4</SystemFormatsTarTestDataVersion>
<SystemIOCompressionTestDataVersion>8.0.0-beta.24108.4</SystemIOCompressionTestDataVersion>
<SystemIOPackagingTestDataVersion>8.0.0-beta.24108.4</SystemIOPackagingTestDataVersion>
<SystemNetTestDataVersion>8.0.0-beta.24108.4</SystemNetTestDataVersion>
<SystemPrivateRuntimeUnicodeDataVersion>8.0.0-beta.24108.4</SystemPrivateRuntimeUnicodeDataVersion>
<SystemRuntimeTimeZoneDataVersion>8.0.0-beta.24108.4</SystemRuntimeTimeZoneDataVersion>
<SystemSecurityCryptographyX509CertificatesTestDataVersion>8.0.0-beta.24108.4</SystemSecurityCryptographyX509CertificatesTestDataVersion>
<SystemTextRegularExpressionsTestDataVersion>8.0.0-beta.24108.4</SystemTextRegularExpressionsTestDataVersion>
<SystemWindowsExtensionsTestDataVersion>8.0.0-beta.24108.4</SystemWindowsExtensionsTestDataVersion>
<MicrosoftDotNetCilStripSourcesVersion>8.0.0-beta.24108.4</MicrosoftDotNetCilStripSourcesVersion>
<!-- dotnet-optimization dependencies -->
<optimizationwindows_ntx64MIBCRuntimeVersion>1.0.0-prerelease.23566.3</optimizationwindows_ntx64MIBCRuntimeVersion>
<optimizationwindows_ntx86MIBCRuntimeVersion>1.0.0-prerelease.23566.3</optimizationwindows_ntx86MIBCRuntimeVersion>
Expand Down Expand Up @@ -186,7 +186,7 @@
<MicrosoftDotNetXHarnessTestRunnersCommonVersion>8.0.0-prerelease.24060.1</MicrosoftDotNetXHarnessTestRunnersCommonVersion>
<MicrosoftDotNetXHarnessTestRunnersXunitVersion>8.0.0-prerelease.24060.1</MicrosoftDotNetXHarnessTestRunnersXunitVersion>
<MicrosoftDotNetXHarnessCLIVersion>8.0.0-prerelease.24060.1</MicrosoftDotNetXHarnessCLIVersion>
<MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>8.0.0-alpha.0.24060.1</MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>
<MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>8.0.0-alpha.0.24072.2</MicrosoftDotNetHotReloadUtilsGeneratorBuildToolVersion>
<XUnitVersion>2.4.2</XUnitVersion>
<XUnitAnalyzersVersion>1.0.0</XUnitAnalyzersVersion>
<XUnitRunnerVisualStudioVersion>2.4.5</XUnitRunnerVisualStudioVersion>
Expand Down Expand Up @@ -240,7 +240,7 @@
Note: when the name is updated, make sure to update dependency name in eng/pipelines/common/xplat-setup.yml
like - DarcDependenciesChanged.Microsoft_NET_Workload_Emscripten_Current_Manifest-8_0_100_Transport
-->
<MicrosoftNETWorkloadEmscriptenCurrentManifest80100Version>8.0.2</MicrosoftNETWorkloadEmscriptenCurrentManifest80100Version>
<MicrosoftNETWorkloadEmscriptenCurrentManifest80100Version>8.0.3</MicrosoftNETWorkloadEmscriptenCurrentManifest80100Version>
<MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest80100Version)</MicrosoftNETRuntimeEmscriptenVersion>
<!-- workloads -->
<SwixPackageVersion>1.1.87-gba258badda</SwixPackageVersion>
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/libraries/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:

# Linux PPC64le
- ${{ if eq(parameters.platform, 'linux_ppc64le') }}:
- Ubuntu.2004.PPC64le.Experimental.Open
- Ubuntu.2204.PPC64le.Experimental.Open

# OSX arm64
- ${{ if eq(parameters.platform, 'osx_arm64') }}:
Expand Down
4 changes: 3 additions & 1 deletion src/coreclr/debug/shared/dbgtransportsession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2499,9 +2499,11 @@ DWORD DbgTransportSession::GetEventSize(DebuggerIPCEvent *pEvent)
break;

case DB_IPCE_DISABLE_OPTS:
cbAdditionalSize = sizeof(pEvent->DisableOptData);
break;

default:
printf("Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK));
STRESS_LOG1(LF_CORDB, LL_INFO1000, "Unknown debugger event type: 0x%x\n", (pEvent->type & DB_IPCE_TYPE_MASK));
_ASSERTE(!"Unknown debugger event type");
}

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/hwintrinsicxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ GenTree* Compiler::impNonConstFallback(NamedIntrinsic intrinsic, var_types simdT
GenTree* op2 = impPopStack().val;
GenTree* op1 = impSIMDPopStack();

GenTree* tmpOp = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op2, CORINFO_TYPE_INT, 16);
GenTree* tmpOp = gtNewSimdCreateScalarNode(TYP_SIMD16, op2, CORINFO_TYPE_INT, 16);
return gtNewSimdHWIntrinsicNode(simdType, op1, tmpOp, intrinsic, simdBaseJitType, genTypeSize(simdType));
}

Expand Down
3 changes: 2 additions & 1 deletion src/coreclr/jit/importercalls.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8290,7 +8290,8 @@ GenTree* Compiler::impMinMaxIntrinsic(CORINFO_METHOD_HANDLE method,

if (isNumber)
{
std::swap(op1, op2);
// Swap the operands so that the cnsNode is op1, this prevents
// the unknown value (which could be NaN) from being selected.

retNode->AsHWIntrinsic()->Op(1) = op2;
retNode->AsHWIntrinsic()->Op(2) = op1;
Expand Down
10 changes: 10 additions & 0 deletions src/coreclr/jit/morph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10724,6 +10724,16 @@ GenTree* Compiler::fgOptimizeHWIntrinsic(GenTreeHWIntrinsic* node)
break;
}

#if defined(TARGET_XARCH)
if ((node->GetSimdSize() == 8) && !compOpportunisticallyDependsOn(InstructionSet_SSE41))
{
// When SSE4.1 isn't supported then Vector2 only needs a single horizontal add
// which means the result isn't broadcast across the entire vector and we can't
// optimize
break;
}
#endif // TARGET_XARCH

GenTree* op1 = node->Op(1);
GenTree* sqrt = nullptr;
GenTree* toScalar = nullptr;
Expand Down
54 changes: 51 additions & 3 deletions src/coreclr/jit/simd.h
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,23 @@ void EvaluateUnarySimd(genTreeOps oper, bool scalar, var_types baseType, TSimd*
template <typename TBase>
TBase EvaluateBinaryScalarRSZ(TBase arg0, TBase arg1)
{
return arg0 >> (arg1 & ((sizeof(TBase) * 8) - 1));
#if defined(TARGET_XARCH)
if ((arg1 < 0) || (arg1 >= (sizeof(TBase) * 8)))
{
// For SIMD, xarch allows overshifting and treats
// it as zeroing. So ensure we do the same here.
//
// The xplat APIs ensure the shiftAmount is masked
// to be within range, so we can't hit this for them.

return static_cast<TBase>(0);
}
#else
// Other platforms enforce masking in their encoding
assert((arg1 >= 0) && (arg1 < (sizeof(TBase) * 8)));
#endif

return arg0 >> arg1;
}

template <>
Expand Down Expand Up @@ -513,7 +529,22 @@ TBase EvaluateBinaryScalarSpecialized(genTreeOps oper, TBase arg0, TBase arg1)

case GT_LSH:
{
return arg0 << (arg1 & ((sizeof(TBase) * 8) - 1));
#if defined(TARGET_XARCH)
if ((arg1 < 0) || (arg1 >= (sizeof(TBase) * 8)))
{
// For SIMD, xarch allows overshifting and treats
// it as zeroing. So ensure we do the same here.
//
// The xplat APIs ensure the shiftAmount is masked
// to be within range, so we can't hit this for them.

return static_cast<TBase>(0);
}
#else
// Other platforms enforce masking in their encoding
assert((arg1 >= 0) && (arg1 < (sizeof(TBase) * 8)));
#endif
return arg0 << arg1;
}

case GT_OR:
Expand All @@ -535,7 +566,24 @@ TBase EvaluateBinaryScalarSpecialized(genTreeOps oper, TBase arg0, TBase arg1)

case GT_RSH:
{
return arg0 >> (arg1 & ((sizeof(TBase) * 8) - 1));
#if defined(TARGET_XARCH)
if ((arg1 < 0) || (arg1 >= (sizeof(TBase) * 8)))
{
// For SIMD, xarch allows overshifting and treats
// it as propagating the sign bit (returning Zero
// or AllBitsSet). So ensure we do the same here.
//
// The xplat APIs ensure the shiftAmount is masked
// to be within range, so we can't hit this for them.

arg0 >>= ((sizeof(TBase) * 8) - 1);
arg1 = static_cast<TBase>(1);
}
#else
// Other platforms enforce masking in their encoding
assert((arg1 >= 0) && (arg1 < (sizeof(TBase) * 8)));
#endif
return arg0 >> arg1;
}

case GT_RSZ:
Expand Down
Loading