-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Privately expose MsQuic performance counters #98422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
47da7c7
Dump select counters after running functional tests.
rzikm 49142ad
V1 of counter implementation
rzikm 3c84899
Fix compilation
rzikm 52269b1
Switch to Metrics API
rzikm f23ecd4
Code review feedback
rzikm 49be6e4
Rename to QuicTestCollection
rzikm 7c59cd4
Move to instrument per metric
rzikm 976715c
Remove unwanted code
rzikm 1589227
Rename file
rzikm 1a33acf
Redisable paralellization
rzikm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
V1 of counter implementation
- Loading branch information
commit 49142ad2f001f08d210dcabfed2732867134551b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
src/libraries/System.Net.Quic/src/System/Net/Quic/NetEventSource.Quic.Counters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Diagnostics.Tracing; | ||
| using System.Net.Quic; | ||
|
|
||
| using Microsoft.Quic; | ||
| using static Microsoft.Quic.MsQuic; | ||
|
|
||
| namespace System.Net | ||
| { | ||
| internal sealed partial class NetEventSource | ||
| { | ||
| private static readonly long[] s_counters = new long[(int)QUIC_PERFORMANCE_COUNTERS.MAX]; | ||
|
|
||
| private IncrementingPollingCounter? _connCreated; | ||
| private IncrementingPollingCounter? _connHandshakeFail; | ||
| private IncrementingPollingCounter? _connAppReject; | ||
| private IncrementingPollingCounter? _connLoadReject; | ||
|
|
||
| protected override void OnEventCommand(EventCommandEventArgs command) | ||
| { | ||
| if (command.Command == EventCommand.Enable && MsQuicApi.IsQuicSupported) | ||
| { | ||
| _connCreated ??= new IncrementingPollingCounter("CONN_CREATED", this, () => GetCounter(QUIC_PERFORMANCE_COUNTERS.CONN_CREATED)) | ||
| { | ||
| DisplayName = "Connections Created", | ||
| DisplayRateTimeScale = TimeSpan.FromSeconds(1) | ||
| }; | ||
|
|
||
| _connHandshakeFail ??= new IncrementingPollingCounter("CONN_HANDSHAKE_FAIL", this, () => GetCounter(QUIC_PERFORMANCE_COUNTERS.CONN_HANDSHAKE_FAIL)) | ||
| { | ||
| DisplayName = "Connection Handshake Failures", | ||
| DisplayRateTimeScale = TimeSpan.FromSeconds(1) | ||
| }; | ||
|
|
||
| _connAppReject ??= new IncrementingPollingCounter("CONN_APP_REJECT", this, () => GetCounter(QUIC_PERFORMANCE_COUNTERS.CONN_APP_REJECT)) | ||
| { | ||
| DisplayName = "Connections Rejected on Application Layer", | ||
| DisplayRateTimeScale = TimeSpan.FromSeconds(1) | ||
| }; | ||
|
|
||
| _connLoadReject ??= new IncrementingPollingCounter("CONN_LOAD_REJECT", this, () => GetCounter(QUIC_PERFORMANCE_COUNTERS.CONN_LOAD_REJECT)) | ||
| { | ||
| DisplayName = "Connections Rejected due to worker load", | ||
| DisplayRateTimeScale = TimeSpan.FromSeconds(1) | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| [NonEvent] | ||
| private void UpdateCounters() | ||
| { | ||
| // if (!MsQuicApi.IsQuicSupported) | ||
| // { | ||
| // // MsQuicApi static ctor also uses this event source for logging, so if this event source is enabled, logging can | ||
| // // actually transitively call this method. Since IsQuicSupported is set at the very end of that method, we just | ||
| // return; | ||
| // } | ||
|
|
||
| unsafe | ||
| { | ||
| fixed (long* pCounters = s_counters) | ||
| { | ||
| MsQuicHelpers.GetMsQuicParameter(null, QUIC_PARAM_GLOBAL_PERF_COUNTERS, (uint)s_counters.Length * sizeof(long), (byte*)pCounters); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [NonEvent] | ||
| private long GetCounter(QUIC_PERFORMANCE_COUNTERS counter) | ||
| { | ||
| UpdateCounters(); | ||
| return s_counters[(int)counter]; | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.