Skip to content

Add ProducesNetCoreAssets property to Publishing.props #98665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 3 commits into from
Feb 22, 2024
Merged

Add ProducesNetCoreAssets property to Publishing.props #98665

ViktorHofer merged 3 commits into from
Feb 22, 2024

Conversation

@MilenaHristova
Copy link
Contributor

@MilenaHristova MilenaHristova commented Feb 19, 2024

Issue: #98662

@ghost ghost assigned MilenaHristova Feb 19, 2024
@ghost
Copy link

ghost commented Feb 19, 2024

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Issue: #98662

Author: MilenaHristova
Assignees: MilenaHristova
Labels:

area-Infrastructure-libraries
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Feb 19, 2024
Closed
@MilenaHristova MilenaHristova marked this pull request as draft February 20, 2024 10:02
@MilenaHristova MilenaHristova marked this pull request as ready for review February 21, 2024 09:38
@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 22, 2024

LGTM. I pushed another commit to remove a stale comment and the not needed publishingversion property.

@MilenaHristova
Copy link
Contributor Author

MilenaHristova commented Feb 22, 2024

@ViktorHofer I found out this is not enough for runtime since you don't use the default arcade publishing (Publish.proj). I think I can add the manifest data in prepare-artifacts.proj

runtime/src/installer/prepare-artifacts.proj

Line 106 in 24a9069

<ItemsToPush Include="@(NonShippingNupkgToPublishFile)" ManifestArtifactData="NonShipping=true" />
the same way as the NonShipping property

@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 22, 2024

I think I can add the manifest data in prepare-artifacts.proj

Yeah we are very special in that regards unfortunately... Unfortunately I can't help much with that.

@ViktorHofer ViktorHofer merged commit a35e477 into dotnet:main Feb 22, 2024
@MilenaHristova MilenaHristova deleted the publishing-props branch February 22, 2024 15:30
This was referenced Feb 22, 2024
Merged
Closed
@MilenaHristova
Copy link
Contributor Author

MilenaHristova commented Feb 27, 2024

/backport to release/8.0-staging

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/8066100853

@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Merged
4 tasks
MilenaHristova added a commit that referenced this pull request Feb 27, 2024
@MilenaHristova @ViktorHofer
Add ProducesNetCoreAssets property to Publishing.props (#98665)
940f485 
* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

---------

Co-authored-by: Viktor Hofer <[email protected]>
@MilenaHristova MilenaHristova mentioned this pull request Feb 27, 2024
Merged
4 tasks
MilenaHristova added a commit to MilenaHristova/runtime that referenced this pull request Feb 27, 2024
@MilenaHristova @ViktorHofer
Add ProducesNetCoreAssets property to Publishing.props (dotnet#98665)
7d2e339 
* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

---------

Co-authored-by: Viktor Hofer <[email protected]>
@MilenaHristova MilenaHristova mentioned this pull request Feb 27, 2024
Merged
ViktorHofer added a commit that referenced this pull request Mar 6, 2024
@MilenaHristova @ViktorHofer
[release/6.0-staging] Set assets manifest metadata for assets that ge…
1a694d4 
…t shipped with .NET release (#98991)

* Set assets manifest metadata for assets that get shipped with .NET release (#98824)

* add metadata to manifest

* set in ItemDefinitionGroup

* remove from items

* comment

* Add ProducesNetCoreAssets property to Publishing.props (#98665)

* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

---------

Co-authored-by: Viktor Hofer <[email protected]>

---------

Co-authored-by: Viktor Hofer <[email protected]>
ViktorHofer added a commit that referenced this pull request Mar 7, 2024
@github-actions @MilenaHristova @ViktorHofer
[release/7.0-staging] Set assets manifest metadata for assets that ge…
1bc5c6f 
…t shipped with .NET release (#98989)

* add metadata to manifest

* set in ItemDefinitionGroup

* remove from items

* comment

* Add ProducesNetCoreAssets property to Publishing.props (#98665)

* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

---------

Co-authored-by: Viktor Hofer <[email protected]>

---------

Co-authored-by: MilenaHristova <[email protected]>
Co-authored-by: Viktor Hofer <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@MilenaHristova MilenaHristova

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MilenaHristova @ViktorHofer