Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 27, 2024

Backport of #98824 and #98665 to release/7.0-staging

/cc @MilenaHristova

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

---------

Co-authored-by: Viktor Hofer <[email protected]>
@carlossanlop
Copy link
Contributor

Friendly reminder that Monday March 11th is the Code Complete date for the April Release.

Please make sure to get an area owner to code review and sign off, confirm the CI failures are unrelated, send an email to Tactics requesting approval, and once approved, add the servicing-approved label, then you can merge. Otherwise, this change would have to wait until the May release.

@MilenaHristova
Copy link
Contributor

@ViktorHofer can we merge this?

@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Mar 7, 2024
@ViktorHofer ViktorHofer merged commit 1bc5c6f into release/7.0-staging Mar 7, 2024
@ViktorHofer ViktorHofer deleted the backport/pr-98824-to-release/7.0-staging branch March 7, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants