Rationalize default Imports for C# and VB #18921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
JunTaoLuo
reviewed
Jul 14, 2021
| <Import Include="System.Threading.Tasks" Condition="'$(Language)' == 'C#'" /> | ||
|
|
||
| <!-- These imports were not included by default for VB projects prior to .NET 6, so they apply to both languages --> | ||
| <Import Include="System.IO" /> |
Contributor
There was a problem hiding this comment.
Minor nit.
It would be nice to sort the Import items when generating the file now that we organize them logically. We used to preserve the alphabetical order as a side effect of how they are organized but it will no longer be the case after this change. I know it's rare for users to browse to this file, but the fact that it's a visible .cs file for C# projects in the obj directory makes me want to strive for more clean looking file.
JunTaoLuo
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the list of
Importitems for VB to include the Imports that C# by default gets for .NET 6 and higher. This means that VB will now additionally get the following when targeting .NET 6:This also reorganizes the imports so that it's more likely that if we expand the list in the future, we will apply that to both languages.
@KathleenDollard Do you think this is the right thing to do?