[main] Update dependencies from nuget/nuget.client

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

• Subscription: fcb199f6-ff33-44a0-f3ef-08d8e97c775d
• Build: 6.5.0.69
• Date Produced: November 8, 2022 5:03:23 AM UTC
• Commit: 69af0e6768253362c74ef96253619a49bbd1cc8b
• Branch: dev

• Updates:
  • NuGet.Build.Tasks: from 6.5.0-preview.2.67 to 6.5.0-preview.2.69

[erdembayar]

@marcpopMSFT
When do we expect this one to merge? Is there anything blocking?

[dsplaisted]

@erdembayar This test is failing:

sdk/src/Tests/dotnet-list-package.Tests/GivenDotnetListPackage.cs

Lines 142 to 156 in 96fc61c

	public void AssetsPathExistsButNotRestored()
	{
	var testAsset = "NewtonSoftDependentProject";
	var projectDirectory = _testAssetsManager
	.CopyTestAsset(testAsset)
	.WithSource()
	.Path;
	new ListPackageCommand(Log)
	.WithWorkingDirectory(projectDirectory)
	.Execute()
	.Should()
	.Pass()
	.And.HaveStdErr();
	}

It looks like previously if you tried to run dotnet list package on a project that wasn't restored, it would print an error but return success (0) as the exit code. Now it looks like it's returning a failure. Is this an expected change?

[erdembayar]

@erdembayar This test is failing:

sdk/src/Tests/dotnet-list-package.Tests/GivenDotnetListPackage.cs

Lines 142 to 156 in 96fc61c

	public void AssetsPathExistsButNotRestored()
	{
	var testAsset = "NewtonSoftDependentProject";
	var projectDirectory = _testAssetsManager
	.CopyTestAsset(testAsset)
	.WithSource()
	.Path;
	new ListPackageCommand(Log)
	.WithWorkingDirectory(projectDirectory)
	.Execute()
	.Should()
	.Pass()
	.And.HaveStdErr();
	}

It looks like previously if you tried to run dotnet list package on a project that wasn't restored, it would print an error but return success (0) as the exit code. Now it looks like it's returning a failure. Is this an expected change?

Yes, it's expected change. We added non-zero exit codes indicate something wrong with the "dotnet list package" report, so customer need to take a look into it.
You can see spec here.

[dsplaisted]

I've updated the test to account for the changed return code.

FYI @dotnet/dotnet-cli, we should probably document this as a breaking change for .NET 8.